Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent creation fails for Linux machines #23

Closed
joestr opened this issue Jan 10, 2023 · 4 comments · Fixed by #24 or #27
Closed

Agent creation fails for Linux machines #23

joestr opened this issue Jan 10, 2023 · 4 comments · Fixed by #24 or #27

Comments

@joestr
Copy link
Contributor

joestr commented Jan 10, 2023

The preparation for Linux VM is flawed.

While in the prepare script JDK 13 gets downloaded and installed in the start script references a JDK 12 installation.

Prepare script

java_download_url="https://download.java.net/java/GA/jdk13.0.2/d4173c853231432d94f001e99d882ca7/8/GPL/openjdk-13.0.2_linux-x64_bin.tar.gz"

tar -xvf openjdk-13.0.2_linux-x64_bin.tar.gz -C /var/lib/jdk/

Start script

@chadlwilson
Copy link
Member

chadlwilson commented Jan 11, 2023

Thanks, feel free to submit a PR. Seems a trivial mistake able to be worked around by setting JAVA_HOME?

I think it's fair to say that this plugin is somewhat abandoned at the moment. It has never been updated to the latest elastic agent plugin API (#5) so I would be a little surprised if it works on current GoCD versions.

Personally i don't have an Azure account or Azure expertise so if you have a need for this or are using this currently and would like to whip it into shape, help would be welcome.

@joestr
Copy link
Contributor Author

joestr commented Jan 11, 2023

Hi,

Thanks for the response!

I mainly use Azure because they are rather cheap and can spin up Windows VMs comparatively fast.

The latest version of this plugin uses a hacky solution to function properly.

I created a fork where I fixed the scripts. Tackling the API change would take some time since I have to get familiar with the API.

@chadlwilson
Copy link
Member

Thanks - will take a look. Part of the reason that plugin hasn't been updated/re-released for a while is inability for me to sanity test it in a "real" environment. If you are able to help me do so, then that can be remedied.

@joestr
Copy link
Contributor Author

joestr commented Jan 12, 2023

I have some capabilities to test and validate proper functionality in Azure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants