Merge pull request #148 from gocardless/template-changes

Template changes

Author: kclamalex

lib/gocardless_pro/client.rb

@@ -253,7 +253,7 @@ def default_options
           'User-Agent' => "#{user_agent}",
           'Content-Type' => 'application/json',
           'GoCardless-Client-Library' => 'gocardless-pro-ruby',
-          'GoCardless-Client-Version' => '4.1.0'
+          'GoCardless-Client-Version' => '4.2.0'
         }
       }
     end

lib/gocardless_pro/services/negative_balance_limits_service.rb

@@ -39,27 +39,6 @@ def all(options = {})
         ).enumerator
       end
 
-      # Creates a new negative balance limit, which replaces the existing limit (if
-      # present) for that currency and creditor combination.
-      #
-      # Example URL: /negative_balance_limits
-      # @param options [Hash] parameters as a hash, under a params key.
-      def create(options = {})
-        path = '/negative_balance_limits'
-
-        params = options.delete(:params) || {}
-        options[:params] = {}
-        options[:params][envelope_key] = params
-
-        options[:retry_failures] = true
-
-        response = make_request(:post, path, options)
-
-        return if response.body.nil?
-
-        Resources::NegativeBalanceLimit.new(unenvelope_body(response.body), response)
-      end
-
       private
 
       # Unenvelope the response of the body using the service's `envelope_key`

lib/gocardless_pro/version.rb

@@ -3,5 +3,5 @@ module GoCardlessPro
 
 module GoCardlessPro
   # Current version of the GC gem
-  VERSION = '4.1.0'
+  VERSION = '4.2.0'
 end

spec/resources/negative_balance_limit_spec.rb

@@ -105,122 +105,4 @@
       expect(second_response_stub).to have_been_requested
     end
   end
-
-  describe '#create' do
-    subject(:post_create_response) { client.negative_balance_limits.create(params: new_resource) }
-    context 'with a valid request' do
-      let(:new_resource) do
-        {
-
-          'balance_limit' => 'balance_limit-input',
-          'created_at' => 'created_at-input',
-          'currency' => 'currency-input',
-          'id' => 'id-input',
-          'links' => 'links-input'
-        }
-      end
-
-      before do
-        stub_request(:post, %r{.*api.gocardless.com/negative_balance_limits})
-          .with(
-            body: {
-              'negative_balance_limits' => {
-
-                'balance_limit' => 'balance_limit-input',
-                'created_at' => 'created_at-input',
-                'currency' => 'currency-input',
-                'id' => 'id-input',
-                'links' => 'links-input'
-              }
-            }
-          )
-          .to_return(
-            body: {
-              'negative_balance_limits' =>
-
-                {
-
-                  'balance_limit' => 'balance_limit-input',
-                  'created_at' => 'created_at-input',
-                  'currency' => 'currency-input',
-                  'id' => 'id-input',
-                  'links' => 'links-input'
-                }
-
-            }.to_json,
-            headers: response_headers
-          )
-      end
-
-      it 'creates and returns the resource' do
-        expect(post_create_response).to be_a(GoCardlessPro::Resources::NegativeBalanceLimit)
-      end
-    end
-
-    context 'with a request that returns a validation error' do
-      let(:new_resource) { {} }
-
-      before do
-        stub_request(:post, %r{.*api.gocardless.com/negative_balance_limits}).to_return(
-          body: {
-            error: {
-              type: 'validation_failed',
-              code: 422,
-              errors: [
-                { message: 'test error message', field: 'test_field' }
-              ]
-            }
-          }.to_json,
-          headers: response_headers,
-          status: 422
-        )
-      end
-
-      it 'throws the correct error' do
-        expect { post_create_response }.to raise_error(GoCardlessPro::ValidationError)
-      end
-    end
-
-    context 'with a request that returns an idempotent creation conflict error' do
-      let(:id) { 'ID123' }
-
-      let(:new_resource) do
-        {
-
-          'balance_limit' => 'balance_limit-input',
-          'created_at' => 'created_at-input',
-          'currency' => 'currency-input',
-          'id' => 'id-input',
-          'links' => 'links-input'
-        }
-      end
-
-      let!(:post_stub) do
-        stub_request(:post, %r{.*api.gocardless.com/negative_balance_limits}).to_return(
-          body: {
-            error: {
-              type: 'invalid_state',
-              code: 409,
-              errors: [
-                {
-                  message: 'A resource has already been created with this idempotency key',
-                  reason: 'idempotent_creation_conflict',
-                  links: {
-                    conflicting_resource_id: id
-                  }
-                }
-              ]
-            }
-          }.to_json,
-          headers: response_headers,
-          status: 409
-        )
-      end
-
-      it 'raises an InvalidStateError' do
-        expect { post_create_response }.to raise_error(GoCardlessPro::InvalidStateError)
-        expect(post_stub).to have_been_requested
-      end
-    end
-  end
 end

spec/services/negative_balance_limits_service_spec.rb

@@ -229,145 +229,4 @@
       end
     end
   end
-
-  describe '#create' do
-    subject(:post_create_response) { client.negative_balance_limits.create(params: new_resource) }
-    context 'with a valid request' do
-      let(:new_resource) do
-        {
-
-          'balance_limit' => 'balance_limit-input',
-          'created_at' => 'created_at-input',
-          'currency' => 'currency-input',
-          'id' => 'id-input',
-          'links' => 'links-input'
-        }
-      end
-
-      before do
-        stub_request(:post, %r{.*api.gocardless.com/negative_balance_limits})
-          .with(
-            body: {
-              'negative_balance_limits' => {
-
-                'balance_limit' => 'balance_limit-input',
-                'created_at' => 'created_at-input',
-                'currency' => 'currency-input',
-                'id' => 'id-input',
-                'links' => 'links-input'
-              }
-            }
-          )
-          .to_return(
-            body: {
-              'negative_balance_limits' =>
-
-                {
-
-                  'balance_limit' => 'balance_limit-input',
-                  'created_at' => 'created_at-input',
-                  'currency' => 'currency-input',
-                  'id' => 'id-input',
-                  'links' => 'links-input'
-                }
-
-            }.to_json,
-            headers: response_headers
-          )
-      end
-
-      it 'creates and returns the resource' do
-        expect(post_create_response).to be_a(GoCardlessPro::Resources::NegativeBalanceLimit)
-      end
-
-      describe 'retry behaviour' do
-        before { allow_any_instance_of(GoCardlessPro::Request).to receive(:sleep) }
-
-        it 'retries timeouts' do
-          stub = stub_request(:post, %r{.*api.gocardless.com/negative_balance_limits})
-                 .to_timeout.then.to_return({ status: 200, headers: response_headers })
-
-          post_create_response
-          expect(stub).to have_been_requested.twice
-        end
-
-        it 'retries 5XX errors' do
-          stub = stub_request(:post, %r{.*api.gocardless.com/negative_balance_limits})
-                 .to_return({ status: 502,
-                              headers: { 'Content-Type' => 'text/html' },
-                              body: '<html><body>Response from Cloudflare</body></html>' })
-                 .then.to_return({ status: 200, headers: response_headers })
-
-          post_create_response
-          expect(stub).to have_been_requested.twice
-        end
-      end
-    end
-
-    context 'with a request that returns a validation error' do
-      let(:new_resource) { {} }
-
-      before do
-        stub_request(:post, %r{.*api.gocardless.com/negative_balance_limits}).to_return(
-          body: {
-            error: {
-              type: 'validation_failed',
-              code: 422,
-              errors: [
-                { message: 'test error message', field: 'test_field' }
-              ]
-            }
-          }.to_json,
-          headers: response_headers,
-          status: 422
-        )
-      end
-
-      it 'throws the correct error' do
-        expect { post_create_response }.to raise_error(GoCardlessPro::ValidationError)
-      end
-    end
-
-    context 'with a request that returns an idempotent creation conflict error' do
-      let(:id) { 'ID123' }
-
-      let(:new_resource) do
-        {
-
-          'balance_limit' => 'balance_limit-input',
-          'created_at' => 'created_at-input',
-          'currency' => 'currency-input',
-          'id' => 'id-input',
-          'links' => 'links-input'
-        }
-      end
-
-      let!(:post_stub) do
-        stub_request(:post, %r{.*api.gocardless.com/negative_balance_limits}).to_return(
-          body: {
-            error: {
-              type: 'invalid_state',
-              code: 409,
-              errors: [
-                {
-                  message: 'A resource has already been created with this idempotency key',
-                  reason: 'idempotent_creation_conflict',
-                  links: {
-                    conflicting_resource_id: id
-                  }
-                }
-              ]
-            }
-          }.to_json,
-          headers: response_headers,
-          status: 409
-        )
-      end
-
-      it 'raises an InvalidStateError' do
-        expect { post_create_response }.to raise_error(GoCardlessPro::InvalidStateError)
-        expect(post_stub).to have_been_requested
-      end
-    end
-  end
 end