Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Permalinks to Comments #272

Open
devadattas opened this issue Jun 13, 2024 · 11 comments
Open

Add Permalinks to Comments #272

devadattas opened this issue Jun 13, 2024 · 11 comments

Comments

@devadattas
Copy link

Description:

We need to add the functionality of permalinks to comments within the Vikunja application. This will allow users to directly link to specific comments, enhancing the usability and navigation of the comment section.

Acceptance Criteria:

  1. Each comment should have a unique permalink.
  2. The permalink should be easily accessible from the comment interface (e.g., a link icon next to each comment).
  3. Clicking on a permalink should navigate the user directly to the corresponding comment, highlighting it or bringing it into view.
  4. Permalinks should be shareable and retain functionality across different devices and sessions.

Technical Notes:

  • Ensure the permalink format is consistent with Vikunja's existing URL structure.
  • Update the comment component to include the permalink feature.
  • Test for cross-browser compatibility and responsiveness.

Additional Information:
This feature request stems from user feedback indicating the difficulty in referencing specific comments in long threads. Implementing permalinks will significantly improve the user experience.

@Benimautner
Copy link

I'm guessing you're talking about the web frontend for vikunja? This repository is for the Android app, and we don't even have comment support yet.

You probably want to head there: https://kolaente.dev/vikunja/vikunja

@kolaente

@Benimautner Benimautner added the wontfix This will not be worked on label Jun 13, 2024
@kolaente kolaente transferred this issue from go-vikunja/app Jun 13, 2024
@kolaente kolaente removed the wontfix This will not be worked on label Jun 13, 2024
@kolaente
Copy link
Member

I've added an item to the backlog about this - for the web version.

@devadattas
Copy link
Author

@kolaente
Copy link
Member

Yes.

@devadattas
Copy link
Author

Wondering if I could add PRs to this repository?

@kolaente
Copy link
Member

You mean here on GitHub? That is not possible unfortunately because the CI runs only on the Gitea instance. You can send a PR there.

Also check out our contribution guidelines.

@devadattas
Copy link
Author

I have tried logging into https://kolaente.dev/vikunja/vikunja

But it won't let me login.

image

@kolaente
Copy link
Member

I've enabled your account, you should be able to send a PR now.

We have a spam problem on the Gitea instance and the only thing which really works is manually enabling accounts.

@devadattas
Copy link
Author

You said:

#272 (comment)

I've added an item to the backlog about this - for the web version.

Could you please point me to the ticket at https://kolaente.dev/ ?

@devadattas
Copy link
Author

Please check https://kolaente.dev/vikunja/vikunja/issues/2441 and the corresponding PR at https://kolaente.dev/vikunja/vikunja/pulls/2442

@kolaente
Copy link
Member

Could you please point me to the ticket at https://kolaente.dev/ ?

There's no issue on the Gitea instance, but a task here: https://my.vikunja.cloud/tasks/20650#share-auth-token=UrdhKPqumxDXUbYpEGJLSIyNTwAnbBzVlwdDpRbv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants