-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uploading an image via the comment section breaks task view #122
Comments
Can you reproduce this with the latest release? (0.22.1) |
Hey, I'm using the same vikunja instance as @Spiritreader
Partly. If I upload an image with the image button I still get the issue right after I inserted it. However, once I completely close the tab and re-open vikunja, the issue is gone. This doesn't work:
This works:
This also occurs on the vikunja demo site. |
Does this only happen with images uploaded via a comment or with task descriptions as well? (They use the same upload mechanism) |
This is definitely a bug. I'll take a look. |
The actual error message seems to be caused by vue trying to insert the image as a child node of a The best solution here would probably be to not manipulate the image element in html directly and use vue itself. Not sure if that's possible. EDIT: Looks like the image manipulation itself is not the problem. This also fails with the default image component. |
Description
When adding a new image via the comment section by clicking on the image icon, after the image has been uploaded, it is no longer possible to navigate the site if you're in the
/tasks/xyz
view.When in Kanban mode, trying to close the task popup results in vikunja doing a browser does nothing, and clicking on a blank space causes the browser to back-navigate for each click.
I've attached screenshots and a gif that describes the issue.
Attachments itself work fine, it's just adding an image as comment that causes this.
Vikunja Frontend Version
0.22.0
Vikunja API Version
v0.22.0
Browser and version
Firefox 123.03b / Vivaldi 6.5.3206.57
Can you reproduce the bug on the Vikunja demo site?
Yes
Screenshots
Task after uploading attachment via the image icon
![image](https://private-user-images.githubusercontent.com/18438899/300299754-9e40b939-afb0-432c-bab0-bb073ea995ca.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAxODIxNDQsIm5iZiI6MTcyMDE4MTg0NCwicGF0aCI6Ii8xODQzODg5OS8zMDAyOTk3NTQtOWU0MGI5MzktYWZiMC00MzJjLWJhYjAtYmIwNzNlYTk5NWNhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA1VDEyMTcyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE5ZTY4NGU0YzQxOWM4NDA0OGQzZjliMDc2ZjllMzMxMmJjYzcwYjRhNjczMjlkNzA2NDhhOWVmN2MzOGJiMmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.EKepM-9pVtpevUQrBTUgh7wLAvEbUuHqMxNgsVXF5gI)
After adding a photo the console shows this
![image](https://private-user-images.githubusercontent.com/18438899/300299732-17f7da52-5c28-4b27-a629-4306b666081e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAxODIxNDQsIm5iZiI6MTcyMDE4MTg0NCwicGF0aCI6Ii8xODQzODg5OS8zMDAyOTk3MzItMTdmN2RhNTItNWMyOC00YjI3LWE2MjktNDMwNmI2NjYwODFlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA1VDEyMTcyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIzYjBjYWIwOTA4N2U1YzA3NDc1MmZjODg1ODdhMTRmNzIzMTgyMzAxNTU4YmU5MzM1ZTkxZjU1N2JlNGRhYzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.0ZtWRxFhlMLX41sQQee0rAcRegn4TOWIGRCn5LFu2m4)
Gif of issue
![vikunja_image_comments](https://private-user-images.githubusercontent.com/18438899/300300451-e92b937a-1b5d-4437-baa9-e9bea68375ff.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAxODIxNDQsIm5iZiI6MTcyMDE4MTg0NCwicGF0aCI6Ii8xODQzODg5OS8zMDAzMDA0NTEtZTkyYjkzN2EtMWI1ZC00NDM3LWJhYTktZTliZWE2ODM3NWZmLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA1VDEyMTcyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdiM2Q3YjQ1NDlmODY3NzBmMzNjNWU3YzQ4M2Q4YjQyMGFjNGYyMWI3NDc4NmI3ZDU3NjRiMjdlMzkxNzc0ZDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.7tOsPzWXuheVf57aoISNpJBP7lQfJHvjianBwMxwffA)
The text was updated successfully, but these errors were encountered: