From 93571138ad3f66fc12149b645b0ba78b2efb12d7 Mon Sep 17 00:00:00 2001
From: dave vader <48764154+plyr4@users.noreply.github.com>
Date: Mon, 13 May 2024 09:34:05 -0500
Subject: [PATCH] chore: rename settings FromAPI constructor (#1126)

Co-authored-by: Easton Crupper <65553218+ecrupper@users.noreply.github.com>
---
 database/settings/create.go     | 2 +-
 database/settings/update.go     | 2 +-
 database/types/settings.go      | 4 ++--
 database/types/settings_test.go | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/database/settings/create.go b/database/settings/create.go
index 0e86f7fbc..7775fb4c9 100644
--- a/database/settings/create.go
+++ b/database/settings/create.go
@@ -14,7 +14,7 @@ func (e *engine) CreateSettings(_ context.Context, s *settings.Platform) (*setti
 	e.logger.Tracef("creating platform settings in the database with %v", s.String())
 
 	// cast the api type to database type
-	settings := types.FromAPI(s)
+	settings := types.SettingsFromAPI(s)
 
 	// validate the necessary fields are populated
 	err := settings.Validate()
diff --git a/database/settings/update.go b/database/settings/update.go
index b72b4d543..c8a3e1679 100644
--- a/database/settings/update.go
+++ b/database/settings/update.go
@@ -14,7 +14,7 @@ func (e *engine) UpdateSettings(_ context.Context, s *settings.Platform) (*setti
 	e.logger.Trace("updating platform settings in the database")
 
 	// cast the api type to database type
-	dbS := types.FromAPI(s)
+	dbS := types.SettingsFromAPI(s)
 
 	// validate the necessary fields are populated
 	err := dbS.Validate()
diff --git a/database/types/settings.go b/database/types/settings.go
index f17bac54b..ea0d47a2a 100644
--- a/database/types/settings.go
+++ b/database/types/settings.go
@@ -194,9 +194,9 @@ func (ps *Platform) Validate() error {
 	return nil
 }
 
-// FromAPI converts the API Settings type
+// SettingsFromAPI converts the API Settings type
 // to a database Settings type.
-func FromAPI(s *settings.Platform) *Platform {
+func SettingsFromAPI(s *settings.Platform) *Platform {
 	settings := &Platform{
 		ID: sql.NullInt64{Int64: s.GetID(), Valid: true},
 		Compiler: Compiler{
diff --git a/database/types/settings_test.go b/database/types/settings_test.go
index 973e5d88d..40285eb34 100644
--- a/database/types/settings_test.go
+++ b/database/types/settings_test.go
@@ -166,7 +166,7 @@ func TestTypes_Platform_PlatformFromAPI(t *testing.T) {
 	want := testPlatform()
 
 	// run test
-	got := FromAPI(s)
+	got := SettingsFromAPI(s)
 
 	if !reflect.DeepEqual(got, want) {
 		t.Errorf("PlatformFromAPI is %v, want %v", got, want)