Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json schema doesn't validate continue in ruleset correctly #490

Closed
wass3r opened this issue Feb 4, 2022 · 1 comment
Closed

json schema doesn't validate continue in ruleset correctly #490

wass3r opened this issue Feb 4, 2022 · 1 comment
Labels
bug Indicates a bug

Comments

@wass3r
Copy link
Collaborator

wass3r commented Feb 4, 2022 •
edited
Loading

Description

The JSON schema currently barks at you for ruleset definitions such as:
image

That is, in fact, a valid and working ruleset, so the JSON schema needs to be adjusted to properly validate this scenario.

Value

The JSON schema should be a reliable tool to validate pipelines.

Useful Information

  1. What is the output of vela --version?
  1. What operating system is being used?
  1. Any other important details?
@wass3r wass3r added the bug Indicates a bug label Feb 4, 2022
@wass3r
Copy link
Collaborator Author

wass3r commented May 10, 2023

fixed by go-vela/types#288

@wass3r wass3r closed this as completed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wass3r