Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove driver related bloat from go.mod #215

Open
slsyy opened this issue Aug 3, 2024 · 4 comments
Open

Remove driver related bloat from go.mod #215

slsyy opened this issue Aug 3, 2024 · 4 comments

Comments

@slsyy
Copy link
Contributor

slsyy commented Aug 3, 2024

Right now the go.mod contains a lot of dependencies from specific driver libraries. However they are not used at all in the core library, because each implementation use the standard database/sql interface.

Problems with that approach:

Maybe it would be helpful to extract all of the test to separe go.mod within the repo, so the core library is super lean. @andreynering WDYT?

@andreynering
Copy link
Contributor

andreynering commented Aug 4, 2024

Hey @slsyy,

I always wanted to solve this problem, but never knew how exactly, and didn't have a lot of time to try.

On other package panagers (Bundler for Ruby, etc) you specify a dependency as being dev or test, so it is ignored on importers, but Go do not have such concept.

If you think having a separate go.mod would work, I'm more than happy to review a pull request for it.

@wxiaoguang
Copy link
Contributor

also: Split database supports into separate packages? #241

@ccoVeille
Copy link

Maybe it would be helpful to extract all of the test to separe go.mod within the repo, so the core library is super lean

I also think it's a good approach.

@ccoVeille
Copy link

I also suggested something here

#241 (comment)

Please tell me if you think it could help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants