(Feat) Adding args and command override to values.yaml #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p2p in kubernets, see values.yaml for examples Signed-off-by: Lenaxia <[email protected]>
Signed-off-by: Lenaxia <[email protected]>
|
Additional changes will be coming to actually allow for worker and main pods. So we can hold off on review for now. This will likely be a major version bump. |
Signed-off-by: Lenaxia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not see a way to modify the run command for the main container. This means that there is no way to enable p2p or anything else that requires command line flags.
Added a command and args entry to the values.yaml which appends or overrides to the command field in the deployment.yaml allowing the usages of additional flags when running.