v3.3/glfw: add openbsd support #336
Conversation
partially fixes #288 change freebsd specific code to be more general add openbsd specific build tags where necessary
|
Nice! This looks good to me but I'd like to defer this to other reviewers. Can we support NetBSD in the same way? |
|
netbsd support seems blocked by missing support in go-gl/glow and godbus/dbus. but yes, a very similar set of changes will work for netbsd once those support it |
|
If there is no objection, I'll merge this. |
since pkg-config gets CFLAGS for glfw3, we don't need to explicitly specify the openbsd x11 include path
There was a problem hiding this comment.
Really nice work in this. I'm very interested in giving it a go running Fyne on OpenBSD :)
Can we please get the install instructions in the README updated for OpenBSD (possibly NetBSD also if that starts working)? I realise that FreeBSD isn't there but that might be outside the work of this PR, I guess?
|
@ilylily would it be possible to have this change with |
simply include standard X11 paths so that the included glfw source compiles on openbsd
removes the need to explicitly specify standard X11 directories
|
Thanks for the fix. I left a comment. |
sort bsd pkg-config lines for readability
|
Note that we should address #313 later. I hope we can use the same way as OpenBSD. |
|
As I said earlier, I also think we should update the README with installation instructions for OpenBSD. |
Oh sorry I missed that. @ilylily Could you create a PR to update README? Thanks, |
partially fixes #288
simple adaptations to add openbsd support. this makes
fyne.io/fyne/v2/cmd/fyne_demo/run on my OpenBSD-current machine. i don't have a netbsd system available, but hopefully this makes it clear which 8-ish changes a netbsd user would need to make to support that too