Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of unnecessary/repetitive unlocked icons in commit list #33385

Closed
CrimsonEdgeHope opened this issue Jan 25, 2025 · 3 comments · Fixed by #33387
Closed

Lots of unnecessary/repetitive unlocked icons in commit list #33385

CrimsonEdgeHope opened this issue Jan 25, 2025 · 3 comments · Fixed by #33387
Labels
type/bug

Comments

@CrimsonEdgeHope
Copy link
Contributor

Description

Too many unlocked icon in commit list, especially for unsigned commits, simply no need of an "unverified" icon, unless adding vigilant mode as what GitHub does. (example on demo site: https://demo.gitea.com/lunny/TheSession-data/commits/branch/main)

#10425 looks quite smooth and distinguished.
While changes from #31160 simply determines the icon display by whether commit signed (verified) or not. https://github.com/go-gitea/gitea/blob/079a1ffe8f38e0c7570079b21a4d8cec4d90e923/templates/repo/commit_sign_badge.tmpl

Screenshots

Image

Image

Gitea Version

7da8a01

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

No response

Browser Version

Firefox 134.0
@CrimsonEdgeHope CrimsonEdgeHope added topic/ui Change the appearance of the Gitea UI type/bug labels Jan 25, 2025
@lunny lunny added type/proposal The new feature has not been accepted yet but needs to be discussed first. proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. and removed type/bug labels Jan 25, 2025
@lunny
Copy link
Member

lunny commented Jan 25, 2025

I think this proposal is acceptable from this side but that's not a bug.

@wxiaoguang
Copy link
Contributor

I think it is a bug, we should avoid showing unnecessary locks.

@wxiaoguang wxiaoguang added type/bug and removed type/proposal The new feature has not been accepted yet but needs to be discussed first. topic/ui Change the appearance of the Gitea UI proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. labels Jan 25, 2025
@wxiaoguang wxiaoguang mentioned this issue Jan 25, 2025
Merged
@wxiaoguang
Copy link
Contributor

The fix could be like this: Do not show unnecessary commit sign lock icon #33387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not show unnecessary commit sign lock icon wxiaoguang/gitea
3 participants
@lunny @wxiaoguang @CrimsonEdgeHope