Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor misalignment with Code button on source pages #33344

Closed
wolfbeast opened this issue Jan 21, 2025 · 1 comment · Fixed by #33345
Closed

Minor misalignment with Code button on source pages #33344

wolfbeast opened this issue Jan 21, 2025 · 1 comment · Fixed by #33345
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.23.2

Comments

@wolfbeast
Copy link

Description

Minor issue with UI styling since 1.23 upgrade:
The "Code" button top-right has misaligned text/glyphs. The text bottoms out, <> seems to be a bit too high. Perhaps font-metrics related? If I disable the UI font everything falls into place normally.
This is on Windows 10. I've tried both Basilisk (UXP) and Edge. Both display the problem to varying degrees.

Screenshots

Image
Image

Gitea Version

1.23.1

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Windows 10 (latest)

Browser Version

Basilisk 2025.01.04 and Microsoft Edge Version 131.0.2903.146 (Official build)
@wolfbeast wolfbeast added topic/ui Change the appearance of the Gitea UI type/bug labels Jan 21, 2025
@silverwind silverwind mentioned this issue Jan 21, 2025
Merged
@silverwind
Copy link
Member

silverwind commented Jan 21, 2025 •
edited
Loading

#33345 will fix it. You are right, the problem is font glyph height dependant.

@lunny lunny added this to the 1.23.2 milestone Jan 22, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jan 22, 2025
@silverwind @wxiaoguang @GiteaBot
Fix code button alignment (go-gitea#33345)
ccbace7 
Fixes: go-gitea#33344

Co-authored-by: wxiaoguang <[email protected]>
@GiteaBot GiteaBot mentioned this issue Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.23.2
Development

Successfully merging a pull request may close this issue.

Fix code button alignment silverwind/gitea
3 participants
@lunny @silverwind @wolfbeast