-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Config Management/Stateless Runner Deploy Workflows #23703
Comments
related: #23643 |
tokens should be reused, I think maybe we can change the current logic. |
I too ran into this problem while writing my ansible role for runner deployment, reusable tokens (similar to the way gitlab does it) sound like the best approach to me. |
Exactly where I ran into it as well - writing an idiomatic ansible role was almost impossible as-is. |
Woodpecker and Drone accept a symmetic secret via environment variables for both the application and the runners, making automated provisioning zero-touch. Could such a flow be considered for Gitea? |
I don't really understand why a separate token mechanism was implemented for runner registration in the first place. I would suggest to remove it and instead introduce a new scope into the gitea access tokens that allows registering runners, e.g. |
If you only use PAT to register runners, how do Gitea know the scope level (org, repo, global) of the runners. |
@sillyguodong True, then maybe the Gitea token can be extended to be "fine grained". https://github.blog/2022-10-18-introducing-fine-grained-personal-access-tokens-for-github/ instead of adding/maintaining a parallel token infrastructure only for the purpose of runner registration tokens. |
Wasn't this done in #24767? |
How does this solve the issue in a containerized environment, where we usually just have a single docker command/entrypoint? It would be really nice to have exactly what @garymoon suggests: inject the secret at startup from the environment. That way the deployment can give both gitea and the runner the same shared key and they can authenticate automatically after that. No command line. No side channel communication. No post-deploy setup. Just give both the key. |
I was searching for a solution to this, and found myself landing on this same thread 2 months down the line. I have hacks and workarounds for the time being, but I want to describe my use-case to demonstrate how a shared environment variable between gitea and runners for initial setup can help: I'm building a helm chart that includes gitea and act runners, and I want to automate the setup between the two. I believe I could make a sidecar job that connects them using the API, but frankly this approach is more convoluted than I think it should be, and I'm using the following workaround hoping that a better solution comes down the pipeline. Currently, I install the chart with an empty environment variable for the runner token. I then wait for gitea to install and generate its own runner token. At this point, the runners are failing due to no valid token. I go into the UI and copy that token out, pasting it into my chart values.yaml I then update my helm chart with the new values, at which point the runners stop thrashing and connect. This process isnt overly complicated for someone who knows how the setup works under the hood, but it would not be easy to point to my helm chart and tell another dev how to setup my environment. |
Since it's the second time I've hit the same issue with Gitea and it's a show-stopper for using it, I found that fork of gitea supports setting up runners via shared secrets of the box: |
I think this issue has been resolved by
You can find these examples in Gitea's act_runner repository. All of these features in the fork are copied from this repository except the shared secrets feature. |
I propose adding an additional parameter to both the Gitea CLI command and the Gitea API for registering runners. This enhancement would allow users to seamlessly configure predefined secrets for deployment on both the Gitea server and the runner sides. By reusing the existing command-line tools and API endpoints, we can maintain consistency while extending functionality, ensuring a streamlined and efficient process for managing secrets. |
I created the pull request #32878 and will add some tests and docs. Please help to review. |
Thank you. How can I test it? |
The proper fix could be like this: Use env GITEA_RUNNER_REGISTRATION_TOKEN as global runner token #32946 Now, we could just set (I think we will have in 1.23 stable) |
I think we could review and merge the fix into 1.23 and then you could try it with 1.23 nightly (maybe in one day) |
Feature Description
Currently, it seems to register a runner, you must fetch a one-time use token.
This is good, when deploying manually. This is not helpful, however, if you're trying to do things like deploy runners with config management or especially a set of runners in an auto scaling group.
I would like an option to allow either 1) reusable registration tokens or 2) some other way to be able to register multiple runners without admin interaction easily.
Screenshots
No response
The text was updated successfully, but these errors were encountered: