From 1660737ec8234d73a5234da4ae0da2e2ecdace0a Mon Sep 17 00:00:00 2001 From: hiifong Date: Sat, 11 Jan 2025 15:48:13 +0800 Subject: [PATCH] Fix --- modules/git/ref.go | 2 +- modules/git/ref_test.go | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/modules/git/ref.go b/modules/git/ref.go index 25a89c57c8fa8..4b4876243f41d 100644 --- a/modules/git/ref.go +++ b/modules/git/ref.go @@ -105,7 +105,7 @@ func (ref RefName) IsFor() bool { return strings.HasPrefix(string(ref), ForPrefix) } -var forReviewPattern = regexp.MustCompile(ForReviewPrefix + `^[1-9][0-9]\d*$`) +var forReviewPattern = regexp.MustCompile(ForReviewPrefix + `[1-9]\d*$`) func (ref RefName) IsForReview() bool { return forReviewPattern.MatchString(string(ref)) diff --git a/modules/git/ref_test.go b/modules/git/ref_test.go index 58f679b7d6ee8..a1580ce912898 100644 --- a/modules/git/ref_test.go +++ b/modules/git/ref_test.go @@ -26,6 +26,17 @@ func TestRefName(t *testing.T) { assert.Equal(t, "main", RefName("refs/for/main").ForBranchName()) assert.Equal(t, "my/branch", RefName("refs/for/my/branch").ForBranchName()) + // Test for review name + assert.Equal(t, false, RefName("refs/for-review/-1").IsForReview()) + assert.Equal(t, false, RefName("refs/for-review/0").IsForReview()) + assert.Equal(t, false, RefName("refs/for-review/01").IsForReview()) + assert.Equal(t, true, RefName("refs/for-review/1").IsForReview()) + assert.Equal(t, true, RefName("refs/for-review/10").IsForReview()) + assert.Equal(t, true, RefName("refs/for-review/10999").IsForReview()) + assert.Equal(t, false, RefName("refs/for-review/a10").IsForReview()) + assert.Equal(t, false, RefName("refs/for-review/10a").IsForReview()) + assert.Equal(t, false, RefName("refs/for-review/abc").IsForReview()) + // Test commit hashes. assert.Equal(t, "c0ffee", RefName("c0ffee").ShortName()) }