Skip to content

Commit 6488697

Browse files
committed
chore: fix linting issues
1 parent 6df16cd commit 6488697

File tree

4 files changed

+15
-9
lines changed

4 files changed

+15
-9
lines changed

.golangci.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
linters-settings:
2-
govet:
3-
check-shadowing: true
42
gocyclo:
53
min-complexity: 15
64
maligned:
@@ -16,6 +14,10 @@ linters-settings:
1614
line-length: 140
1715
goimports:
1816
local-prefixes: github.com/go-faster/
17+
revive:
18+
rules:
19+
- disabled: true
20+
name: unused-parameter
1921
gocritic:
2022
enabled-tags:
2123
- diagnostic
@@ -101,3 +103,7 @@ issues:
101103
# Ignore linters in main packages.
102104
- path: main\.go
103105
linters: [goconst, funlen, gocognit, gocyclo]
106+
107+
# Too much false-positives.
108+
- linters: [gosec]
109+
text: G115

dec_read.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,16 +120,16 @@ func (d *Decoder) read() error {
120120
return nil
121121
}
122122

123-
func (d *Decoder) readAtLeast(min int) error {
123+
func (d *Decoder) readAtLeast(n int) error {
124124
if d.reader == nil {
125125
d.head = d.tail
126126
return io.ErrUnexpectedEOF
127127
}
128128

129-
if need := min - len(d.buf); need > 0 {
129+
if need := n - len(d.buf); need > 0 {
130130
d.buf = append(d.buf, make([]byte, need)...)
131131
}
132-
n, err := io.ReadAtLeast(d.reader, d.buf, min)
132+
n, err := io.ReadAtLeast(d.reader, d.buf, n)
133133
if err != nil {
134134
if err == io.EOF && n == 0 {
135135
return io.ErrUnexpectedEOF

num.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,15 +135,15 @@ func (n Num) Format(f fmt.State, verb rune) {
135135
case 'd':
136136
d, err := n.Int64()
137137
if err != nil {
138-
fmt.Fprintf(f, "%%!invalid(Num=%s)", n.String())
138+
_, _ = fmt.Fprintf(f, "%%!invalid(Num=%s)", n.String())
139139
return
140140
}
141141
v := big.NewInt(d)
142142
v.Format(f, verb)
143143
case 'f':
144144
d, err := n.Float64()
145145
if err != nil {
146-
fmt.Fprintf(f, "%%!invalid(Num=%s)", n.String())
146+
_, _ = fmt.Fprintf(f, "%%!invalid(Num=%s)", n.String())
147147
return
148148
}
149149
v := big.NewFloat(d)

tools/mkint/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ type IntType struct {
2323
DecoderIterations int // ceil(log10 (max value))
2424
}
2525

26-
func defineIntType(name string, max uint64) IntType {
27-
formattedLen := len(strconv.FormatUint(max, 10))
26+
func defineIntType(name string, maxN uint64) IntType {
27+
formattedLen := len(strconv.FormatUint(maxN, 10))
2828
decoderIters := formattedLen
2929

3030
const decoderItersLimit = 10 - 1

0 commit comments

Comments
 (0)