-
Notifications
You must be signed in to change notification settings - Fork 2.2k
pkg/proc: update riscv64 support and fix several tests #4190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The tests on linux/riscv64 aren't passing because there is no capslock file. Do you mind generating it with Also, while we are at this, the linux/riscv64/tip fails due to a timeout compiling go-tip. I think we should just remove it from the test matrix (we don't test tip on linux/386 and linux/pcc64le either). |
Added, BTW I have to add
Removed, also I'm wondering with CI machine and renewed support, could we start discussing remove the experimental mark of riscv64 support? |
Yes. You also need to add it to TestCapsLock, the same as the if statement for linux/ppc64le.
Yes. |
Added, thanks for the guide. |
450c7df to
0a0e433
Compare
aarzilli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Re-running CI due to all the failures. |
|
I think you may need to update the capslock file. Can you run |
I've run |
Sorry, after updated the capslock version, I've found it generated correctly, also remove the experimental mark. Besides, I've checked with @mengzhuo that the riscv64 ci machine is up-and-running normally, so I've re-added riscv64 in testing matrix, if there are any issues with delve CI machine, we'll try to solve it ASAP. |
derekparker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request adds support for stack-switching functions, contextregnum and sigtramp on riscv64, which fix
TestCgoStacktrace,TestCgoStacktrace2,TestStepIntoCoroutine,TestCapturedVarVisibleOnFirstLineandTestDWZCompression.