Skip to content

Conversation

@lrzlin
Copy link
Contributor

@lrzlin lrzlin commented Oct 29, 2025

This pull request adds support for stack-switching functions, contextregnum and sigtramp on riscv64, which fix TestCgoStacktrace, TestCgoStacktrace2, TestStepIntoCoroutine, TestCapturedVarVisibleOnFirstLine and TestDWZCompression.

@aarzilli
Copy link
Member

The tests on linux/riscv64 aren't passing because there is no capslock file. Do you mind generating it with

capslock -goos linux -goarch riscv64 -packages ./cmd/dlv > _scripts/capslock_linux_riscv64-output.txt

Also, while we are at this, the linux/riscv64/tip fails due to a timeout compiling go-tip. I think we should just remove it from the test matrix (we don't test tip on linux/386 and linux/pcc64le either).

@lrzlin
Copy link
Contributor Author

lrzlin commented Oct 29, 2025

The tests on linux/riscv64 aren't passing because there is no capslock file. Do you mind generating it with

capslock -goos linux -goarch riscv64 -packages ./cmd/dlv > _scripts/capslock_linux_riscv64-output.txt

Added, BTW I have to add GOFLAGS="-tags=exp.linuxriscv64" to generate this, is that okay?

Also, while we are at this, the linux/riscv64/tip fails due to a timeout compiling go-tip. I think we should just remove it from the test matrix (we don't test tip on linux/386 and linux/pcc64le either).

Removed, also I'm wondering with CI machine and renewed support, could we start discussing remove the experimental mark of riscv64 support?

@aarzilli
Copy link
Member

Added, BTW I have to add GOFLAGS="-tags=exp.linuxriscv64" to generate this, is that okay?

Yes. You also need to add it to TestCapsLock, the same as the if statement for linux/ppc64le.

Removed, also I'm wondering with CI machine and renewed support, could we start discussing remove the experimental mark of riscv64 support?

Yes.

@lrzlin
Copy link
Contributor Author

lrzlin commented Oct 29, 2025

Added, BTW I have to add GOFLAGS="-tags=exp.linuxriscv64" to generate this, is that okay?

Yes. You also need to add it to TestCapsLock, the same as the if statement for linux/ppc64le.

Added, thanks for the guide.

@lrzlin lrzlin force-pushed the riscv-update branch 2 times, most recently from 450c7df to 0a0e433 Compare October 31, 2025 11:33
Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker
Copy link
Member

Re-running CI due to all the failures.

@derekparker
Copy link
Member

I think you may need to update the capslock file. Can you run go run _scripts/gen-capslock-all.go?

@lrzlin
Copy link
Contributor Author

lrzlin commented Nov 25, 2025

I think you may need to update the capslock file. Can you run go run _scripts/gen-capslock-all.go?

I've run go run _scripts/gen-capslock-all.go again but there are not any difference with the version I updated.

@lrzlin
Copy link
Contributor Author

lrzlin commented Nov 25, 2025

I think you may need to update the capslock file. Can you run go run _scripts/gen-capslock-all.go?

Sorry, after updated the capslock version, I've found it generated correctly, also remove the experimental mark.

Besides, I've checked with @mengzhuo that the riscv64 ci machine is up-and-running normally, so I've re-added riscv64 in testing matrix, if there are any issues with delve CI machine, we'll try to solve it ASAP.

Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit 9974635 into go-delve:master Nov 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants