Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetWriteDeadline not supported #947

Closed
jzillmann opened this issue Aug 28, 2024 · 1 comment
Closed

SetWriteDeadline not supported #947

jzillmann opened this issue Aug 28, 2024 · 1 comment

Comments

@jzillmann
Copy link

Using huma on top of chi and running into danielgtaylor/huma#491 which means a constant logging of warning: unable to set write deadline.
My uneducated guess is that the go standard connection (https://cs.opensource.google/go/go/+/refs/tags/go1.23.0:src/net/net.go;l=119) supports the SetWriteDeadline but chi's wrapper not !?
@VojtechVitek
Copy link
Contributor

Hi,

Chi's ResponseWriter implements Unwrap() method.

So I believe if Huma used http.ResponseController properly, it would work fine.
I'll leave this to danielgtaylor/huma#491.

Feel free to reopen with a minimal reproducer code if this is indeed Chi bug.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VojtechVitek @jzillmann