Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request.js 逻辑问题 #192

Open
xiyang-2023 opened this issue Aug 10, 2022 · 2 comments
Open

request.js 逻辑问题 #192

xiyang-2023 opened this issue Aug 10, 2022 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@xiyang-2023
Copy link

error => {
if (error.message === 'Network Error') {
Message({
message: '服务器连接异常,请检查服务器!',
type: 'error',
duration: 5 * 1000
})
return //直接return 页面就捕捉不了错误了
}
console.log('err' + error) // for debug

Message({
  message: error.message,
  type: 'error',
  duration: 5 * 1000
})

return Promise.reject(error)

}

@xiyang-2023
Copy link
Author

if (error.message === 'Network Error')
error.message="服务器连接异常,请检查服务器!";

console.log('err' + error) // for debug

Message({
  message: error.message,
  type: 'error',
  duration: 5 * 1000
})

@wenjianzhang
Copy link
Member

Hello @xiyangxiyang. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!
你好 @xiyangxiyang,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。
giphy

@wenjianzhang wenjianzhang added the help wanted Extra attention is needed label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants