Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses minor inconviences. #34

Merged
merged 6 commits into from
Feb 3, 2025
Merged

Addresses minor inconviences. #34

merged 6 commits into from
Feb 3, 2025

Conversation

zy0n
Copy link
Contributor

@zy0n zy0n commented Jan 31, 2025

Issues were found while installing dependencies.

  • Addressed by manually updating lockfile by deleting the offending package from it. subsequentially re-running install.

Missing .env step within README

Skip verify action in hardhat tasks when running on hardhat network.

Incorrect nonce issue due to the single file test flow. Resetting fork state at beginning of each test to match the expected starting state.

Deployment of second mech in test/Mech.ts was not awaiting its promise, causing the tests to fail.

Fixed deterministicDeployment inputs to match contract changes.

Copy link

vercel bot commented Jan 31, 2025

@zy0n is attempting to deploy a commit to the Gnosis Guild Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@jfschwarz jfschwarz merged commit 5110223 into gnosisguild:main Feb 3, 2025
0 of 2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants