diff --git a/.solhint.json b/.solhint.json new file mode 100644 index 00000000..218de574 --- /dev/null +++ b/.solhint.json @@ -0,0 +1,12 @@ +{ + "extends": "default", + "rules": { + "avoid-call-value": "warn", + "const-name-snakecase": "warn", + "func-name-mixedcase": "warn", + "func-order": "warn", + "func-param-name-mixedcase": "warn", + "var-name-mixedcase": "warn", + "visibility-modifier-order": "warn" + } +} diff --git a/contracts/Factory.sol b/contracts/Factory.sol index 18841dd3..6f33a4a9 100644 --- a/contracts/Factory.sol +++ b/contracts/Factory.sol @@ -1,5 +1,6 @@ pragma solidity ^0.4.15; + contract Factory { /* diff --git a/contracts/Migrations.sol b/contracts/Migrations.sol index 0507024f..4e57dbd7 100644 --- a/contracts/Migrations.sol +++ b/contracts/Migrations.sol @@ -1,23 +1,24 @@ pragma solidity ^0.4.15; + contract Migrations { - address public owner; - uint public last_completed_migration; + address public owner; + uint public last_completed_migration; - modifier restricted() { - if (msg.sender == owner) _; - } + modifier restricted() { + if (msg.sender == owner) _; + } - function Migrations() { - owner = msg.sender; - } + function Migrations() { + owner = msg.sender; + } - function setCompleted(uint completed) restricted { - last_completed_migration = completed; - } + function setCompleted(uint completed) restricted { + last_completed_migration = completed; + } - function upgrade(address new_address) restricted { - Migrations upgraded = Migrations(new_address); - upgraded.setCompleted(last_completed_migration); - } + function upgrade(address new_address) restricted { + Migrations upgraded = Migrations(new_address); + upgraded.setCompleted(last_completed_migration); + } } diff --git a/contracts/MultiSigWallet.sol b/contracts/MultiSigWallet.sol index 4b200693..153f14f9 100644 --- a/contracts/MultiSigWallet.sol +++ b/contracts/MultiSigWallet.sol @@ -109,7 +109,7 @@ contract MultiSigWallet { public validRequirement(_owners.length, _required) { - for (uint i=0; i<_owners.length; i++) { + for (uint i = 0; i < _owners.length; i++) { require(!isOwner[_owners[i]] && _owners[i] != 0); isOwner[_owners[i]] = true; } @@ -139,7 +139,7 @@ contract MultiSigWallet { ownerExists(owner) { isOwner[owner] = false; - for (uint i=0; i