Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The README mentions throw-exceptions? instead of throw-exceptions #54

Open
p-himik opened this issue May 9, 2023 · 2 comments
Open

Comments

@p-himik
Copy link

p-himik commented May 9, 2023

The actual keyword is :throw-exceptions: https://github.com/gnarroway/hato/blob/master/src/hato/middleware.clj#L147

@seancorfield
Copy link

That seems at odds with this test: https://github.com/gnarroway/hato/blob/master/test/hato/client_test.clj#L179 so it's not clear how that test passes...?

@p-himik
Copy link
Author

p-himik commented Jul 17, 2023

Ah, because of this: https://github.com/gnarroway/hato/blob/master/src/hato/middleware.clj#L88-L101

Eh, not sure I like that solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants