feat: expose full notice object in JSON output

gmolki · Jan 22, 2020 · bdc2711 · bdc2711
1 parent 498518c
commit bdc2711
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/lib/pact/pact_broker/fetch_pact_uris_for_verification.rb b/lib/pact/pact_broker/fetch_pact_uris_for_verification.rb
@@ -73,7 +73,11 @@ def query
       end
 
       def extract_notices(pact)
-        (pact["verificationProperties"]["notices"] || []).collect{ |notice| notice["text"] }.compact
+        (pact["verificationProperties"]["notices"] || []).collect{ |notice| symbolize_keys(notice) }.compact
+      end
+
+      def symbolize_keys(hash)
+        hash.each_with_object({}){ |(k,v), h| h[k.to_sym] = v }
       end
 
       def log_message

diff --git a/lib/pact/provider/rspec.rb b/lib/pact/provider/rspec.rb
@@ -24,7 +24,7 @@ module ClassMethods
         def honour_pactfile pact_uri, pact_json, options
           Pact.configuration.output_stream.puts "INFO: Reading pact at #{pact_uri}"
           (pact_uri.metadata[:notices] || EMPTY_ARRAY).each do | notice |
-            Pact.configuration.output_stream.puts("DEBUG: #{notice}")
+            Pact.configuration.output_stream.puts("DEBUG: #{notice[:text]}")
           end
           Pact.configuration.output_stream.puts "DEBUG: Filtering interactions by: #{options[:criteria]}" if options[:criteria] && options[:criteria].any?
           consumer_contract = Pact::ConsumerContract.from_json(pact_json)

diff --git a/spec/service_providers/pact_ruby_fetch_pacts_for_verification_test.rb b/spec/service_providers/pact_ruby_fetch_pacts_for_verification_test.rb
@@ -92,7 +92,9 @@
       let(:expected_metadata) do
         {
           pending: true,
-          notices: ["some text"]
+          notices: [
+            text: "some text"
+          ]
          }
       end