Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSIF: document property on Item was renamed to shard in spec #249

Open
DrChat opened this issue Sep 20, 2022 · 0 comments · May be fixed by #250
Open

LSIF: document property on Item was renamed to shard in spec #249

DrChat opened this issue Sep 20, 2022 · 0 comments · May be fixed by #250

Comments

@DrChat
Copy link

DrChat commented Sep 20, 2022 •
edited
Loading

lsp-types/src/lsif.rs

Line 263 in e3afaf2

pub document: Id,

https://microsoft.github.io/language-server-protocol/specifications/lsif/0.6.0/specification/

msedge_yp5YORuwrP

This causes some LSIF parsers to throw errors. The property should be renamed to shard to match the spec, possibly with a #[serde(rename = "shard") attribute to avoid breaking SemVer.
@DrChat DrChat changed the title document property on Item was renamed to shard in spec LSIF: document property on Item was renamed to shard in spec Sep 20, 2022
@DrChat DrChat linked a pull request Sep 22, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename Item::document property to shard to match LSIF spec. DrChat/lsp-types
1 participant
@DrChat