Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pvextractor should not be in install_requires #2316

Closed
pllim opened this issue Aug 17, 2022 · 2 comments
Closed

pvextractor should not be in install_requires #2316

pllim opened this issue Aug 17, 2022 · 2 comments

Comments

@pllim
Copy link
Contributor

pllim commented Aug 17, 2022

glue/setup.cfg

Line 46 in f8c1e96

pvextractor>=0.2

https://github.com/radio-astro-tools/pvextractor/blob/9911f297a7978c8afb3fe6f6d937d6b03161031c/setup.cfg#L24 (it pulls in spectral-cube)

Blocks glue-viz/glue-astronomy#76

@pllim pllim changed the title pxextractor should not be in install_requires pvextractor should not be in install_requires Aug 17, 2022
@astrofrog
Copy link
Member

We do rely on it for some core functionality for now. However I do have a work in progress branch to remove it as we will be doing slicing along paths In a different way.

@pllim why all the spectral-cube dislike?

@pllim
Copy link
Contributor Author

pllim commented Aug 17, 2022

Not particularly targeting on that package. We just want to minimize installing unused packages downstream and that was the one thing we're sure we don't need. Jdaviz is deployed on MAST and so on.

@pllim pllim closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants