Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to import glue-wwt without Qt installed #111

Open
1 of 3 tasks
astrofrog opened this issue May 13, 2024 · 5 comments
Open
1 of 3 tasks

Make it possible to import glue-wwt without Qt installed #111

astrofrog opened this issue May 13, 2024 · 5 comments
Assignees

Comments

@astrofrog
Copy link
Member

astrofrog commented May 13, 2024

Because glue-wwt can be used in a Jupyter context, we should:

  • Make qtpy an optional dependency
  • Add a -qt factor in tox or even pyqt and pyside ones like in glue-qt and then have a mix of builds in CI, some with PyQt, some with PySide, and some without either (and maybe with jupyter stuff I guess)
  • Make sure the test suite skips tests it can't run if Qt isn't available
@Carifio24
Copy link
Member

Carifio24 commented May 24, 2024

We already have qtpy as an optional dependency, and the newest release of pywwt does as well, so the first item should be all set.

@Carifio24
Copy link
Member

@astrofrog While working on this I realized that while we've removed any qtpy dependency from pywwt, we're still pulling in qtpy as it's a dependency of both echo (on which this package depends) and of pvextractor (pulled in from glue-core).

I would think that for echo we should be able to make qtpy an optional dependency, as I imagine it's not needed unless one is using the Qt widget <--> callback linking functions, but I'm pretty unfamiliar with the functionality of pvextractor so I'm not sure how key it is there.

@astrofrog
Copy link
Member Author

echo and glue-core now no longer pull in qtpy, so this should now be possible?

@Carifio24
Copy link
Member

I believe so! I'll check and verify that, and if so I can start addressing the latter two items in the list.

@astrofrog
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants