Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.9.3 #301

Merged
merged 30 commits into from
May 6, 2024
Merged

v0.9.3 #301

merged 30 commits into from
May 6, 2024

Conversation

henriquesposito
Copy link
Collaborator

@henriquesposito henriquesposito commented Apr 8, 2024

Description

This PR fixes issues with reverse dependencies related to the newest release of {messydates}.

Connection

Checklist:

  • PR form
    • I have given this pull request an informative title
    • Description above itemizes changes under subtitles, e.g. "## Collection""
    • Any closed, fixed, or related issues are referenced and explained in the description above, e.g. "Fixed #0 by adding A"
    • Package builds on my OS without issues
  • PR checks all pass for latest commit
    • Package builds on Mac
    • Package builds on Windows
    • Package builds on Linux
    • CodeCov check: Package improves or maintains good test coverage
    • CodeFactor check: Package improves or maintains good style
  • Documentation
    • Any new or modified functions or data have roxygen style documentation in their .R scripts
    • Any longer functions are commented inline so that it is easier to debug in the future
    • PR description above and the NEWS.md file are aligned
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)

henriquesposito and others added 24 commits March 5, 2024 10:44
…tain one dataset or when some of the documentation items are missing.
… working for other datacubes across the many packages
jaeltan
jaeltan previously approved these changes Apr 12, 2024
Copy link
Contributor

@jaeltan jaeltan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work Henrique, just a minor comment on call_sources.

R/call.R Show resolved Hide resolved
@jaeltan jaeltan dismissed their stale review April 12, 2024 08:57

Missed out compare_ranges tests

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 80.39216% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 71.20%. Comparing base (06a7458) to head (036366b).
Report is 3 commits behind head on main.

❗ Current head 036366b differs from pull request most recent head cd81185. Consider uploading reports for the commit cd81185 to get more accurate results

Files Patch % Lines
R/call.R 70.58% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
- Coverage   72.03%   71.20%   -0.84%     
==========================================
  Files           6        6              
  Lines         751      757       +6     
==========================================
- Hits          541      539       -2     
- Misses        210      218       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +32 to +33
skip_on_ci()
skip_on_cran()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe comment that this is because of the manydata/R version issue?

@jhollway jhollway merged commit 49c3a8d into main May 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated documentation for all datasets and databases across for new changes in call_sources()
3 participants