From 10fd0236bce6a55252bbc1e2251e5bd4d3ea8d20 Mon Sep 17 00:00:00 2001
From: Jorrit Poelen <jhpoelen+git@jhpoelen.nl>
Date: Fri, 14 Jun 2024 03:49:34 -0500
Subject: [PATCH] add suspicious name mapping for discoverlife; related to
 https://github.com/globalbioticinteractions/nomer/issues/178

---
 .../globi/taxon/DiscoverLifeUtilXMLTest.java  | 23 ++++++++++
 .../match/discoverlife/bombus_pauloensis.xml  | 44 +++++++++++++++++++
 2 files changed, 67 insertions(+)
 create mode 100644 nomer-taxon-resolver/src/test/resources/org/globalbioticinteractions/nomer/match/discoverlife/bombus_pauloensis.xml

diff --git a/nomer-taxon-resolver/src/test/java/org/eol/globi/taxon/DiscoverLifeUtilXMLTest.java b/nomer-taxon-resolver/src/test/java/org/eol/globi/taxon/DiscoverLifeUtilXMLTest.java
index c1ff8ff6..756488bf 100644
--- a/nomer-taxon-resolver/src/test/java/org/eol/globi/taxon/DiscoverLifeUtilXMLTest.java
+++ b/nomer-taxon-resolver/src/test/java/org/eol/globi/taxon/DiscoverLifeUtilXMLTest.java
@@ -24,6 +24,7 @@
 import java.util.Map;
 
 import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.CoreMatchers.nullValue;
 import static org.hamcrest.MatcherAssert.assertThat;
 
 public class DiscoverLifeUtilXMLTest {
@@ -92,6 +93,28 @@ public void parseRelatedNames() throws ParserConfigurationException, XPathExpres
         assertThat(lastTaxon.getStatus().getName(), is(NameType.SYNONYM_OF.name()));
     }
 
+    @Test
+    public void parseRelatedNamesBombus() throws ParserConfigurationException, XPathExpressionException, IOException, SAXException {
+        // also see https://github.com/globalbioticinteractions/nomer/issues/178
+        Document doc = docForResource("/org/globalbioticinteractions/nomer/match/discoverlife/bombus_pauloensis.xml");
+
+        List<Taxon> taxons = DiscoverLifeUtilXML.parseRelatedNames(doc, new ParserServiceGBIF());
+
+        assertThat(taxons.size(), is(15));
+
+        Taxon lastTaxon = taxons.get(10);
+        assertThat(lastTaxon.getName(), is("Bombus"));
+        assertThat(lastTaxon.getRank(), is("variety"));
+        assertThat(lastTaxon.getAuthorship(), is(nullValue()));
+        assertThat(lastTaxon.getStatus().getName(), is(NameType.SYNONYM_OF.name()));
+
+        lastTaxon = taxons.get(11);
+        assertThat(lastTaxon.getName(), is("Bombus cayennensis var. paufer"));
+        assertThat(lastTaxon.getRank(), is("variety"));
+        assertThat(lastTaxon.getAuthorship(), is("Friese, 1931"));
+        assertThat(lastTaxon.getStatus().getName(), is(NameType.SYNONYM_OF.name()));
+    }
+
     @Test
     public void parseRelatedNamesWithReplacementName() throws ParserConfigurationException, XPathExpressionException, IOException, SAXException {
         Document doc = docForResource("/org/globalbioticinteractions/nomer/match/discoverlife/osmia_versicolor.xml");
diff --git a/nomer-taxon-resolver/src/test/resources/org/globalbioticinteractions/nomer/match/discoverlife/bombus_pauloensis.xml b/nomer-taxon-resolver/src/test/resources/org/globalbioticinteractions/nomer/match/discoverlife/bombus_pauloensis.xml
new file mode 100644
index 00000000..9db925f0
--- /dev/null
+++ b/nomer-taxon-resolver/src/test/resources/org/globalbioticinteractions/nomer/match/discoverlife/bombus_pauloensis.xml
@@ -0,0 +1,44 @@
+<set level="species"><name>Bombus pauloensis</name><authority>Friese, 1913</authority>
+<path>Insecta/Hymenoptera/Apoidea/Apidae</path>
+<common_name language="english">Bombus &#40;Bombus&#41; atratus_homonym Franklin, 1913 Bombus cayennensis var. pauloensis Friese, 1913 Bombus cayennensis var. nigriventris Friese, 1913 Bremus atratus var. alternans Frison, 1925 Bremus atratus var. annulatus Frison, 1925 Bremus niger var. signatus Frison, 1925 Bombus cayennensis var. nigriventris_homonym Friese, 1931 Bombus cayennensis var. albidoanalis Friese, 1931 Bombus cayennensis var. buchwaldi Friese, 1931 Bombus var. cayennensis draenerti Friese, 1931 Bombus var cayennensis jundiahyensis Friese, 1931 Bombus cayennensis var paufer Friese, 1931 Bombus cayennensis var. uberabensis Friese, 1931 Bombus thoracicus var. umbricollis Friese, 1931 Bombus &#40;Fervidobombus&#41; atratus_homonym Franklin, 1913</common_name>
+<who>John Ascher</who><email>dl@discoverlife.org</email>
+<IP_address>107.211.202.217</IP_address>
+<attributes>
+<character>Author</character>
+	<state>Friese</state>
+<character>Country</character>
+	<state>Argentina</state>
+	<state>Bolivia</state>
+	<state>Brazil</state>
+	<state>Colombia</state>
+	<state>Ecuador</state>
+	<state>Paraguay</state>
+	<state>Peru</state>
+	<state>Uruguay</state>
+	<state>Venezuela</state>
+<character>Family</character>
+	<state>Apidae</state>
+<character>Genus</character>
+	<state>Bombus</state>
+<character>Group</character>
+	<state>Bee</state>
+<character>Host insect or prey</character>
+	<state>Other,_unknown,_or_other</state>
+<character>Host plant</character>
+	<state>Other,_unknown,_or_other</state>
+<character>Museum</character>
+	<state>Amnh</state>
+<character>Original genus</character>
+	<state>Bombus</state>
+<character>Region</character>
+	<state>South America</state>
+<character>Subfamily</character>
+	<state>Apinae</state>
+<character>Subgenus</character>
+	<state>Thoracobombus</state>
+<character>Subtribe</character>
+	<state>None</state>
+<character>Tribe</character>
+	<state>Bombini</state>
+</attributes>
+</set>