From c929b51ac0e56390ab2846572e5a96af08fabec5 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Fri, 10 May 2024 11:27:03 -0400 Subject: [PATCH 1/2] [1.x]: Expand try matrix --- .github/workflows/ci.yml | 11 ++++++++--- .../@glimmer/component/config/ember-try.js | 19 +++++++++++++++++++ 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4805237a4..218f50921 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,9 +28,9 @@ jobs: matrix: ember-version: - default - #- release - #- beta - #- canary + - release + - beta + - canary - lts-3.4 - lts-3.8 - lts-3.12 @@ -38,6 +38,11 @@ jobs: - lts-3.20 - lts-3.24 - lts-3.28 + - lts-4.4 + - lts-4.8 + - lts-4.12 + - lts-5.4 + - lts-5.8 steps: - uses: actions/checkout@v2 diff --git a/packages/@glimmer/component/config/ember-try.js b/packages/@glimmer/component/config/ember-try.js index 73733016f..e0531c1f8 100644 --- a/packages/@glimmer/component/config/ember-try.js +++ b/packages/@glimmer/component/config/ember-try.js @@ -3,6 +3,20 @@ const getChannelURL = require('ember-source-channel-url'); module.exports = function() { + function lts(version, extra = {}) { + return { + name: `ember-lts-${version}`, + npm: { + ...extra, + devDependencies: { + 'ember-source': `~${version}.0`, + ...(extra?.devDependencies || {}), + } + + }, + } + } + return Promise.all([ getChannelURL('release'), getChannelURL('beta'), @@ -67,6 +81,11 @@ module.exports = function() { }, }, }, + lts('4.4'), + lts('4.8'), + lts('4.12'), + lts('5.4'), + lts('5.8'), { name: 'ember-release', npm: { From 139e5312bdfde17f4afc0f619254a6bbf32b149e Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Fri, 10 May 2024 11:35:56 -0400 Subject: [PATCH 2/2] Womp, no ?. --- packages/@glimmer/component/config/ember-try.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@glimmer/component/config/ember-try.js b/packages/@glimmer/component/config/ember-try.js index e0531c1f8..7dc63e258 100644 --- a/packages/@glimmer/component/config/ember-try.js +++ b/packages/@glimmer/component/config/ember-try.js @@ -10,7 +10,7 @@ module.exports = function() { ...extra, devDependencies: { 'ember-source': `~${version}.0`, - ...(extra?.devDependencies || {}), + ...(extra && extra.devDependencies || {}), } },