This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 75
Wrong type definitions when using with Ember #179
Labels
Comments
I just checked and the correct info is on |
I want to clarify that the this issue is referring to the type definitions of the component class. See following images: Per Glimmer RFC, we should not have |
Chatted about this a bit in discord, for now the easiest fix is to override in @chriskrycho / @josemarluedke - Could one of y'all paste the snippet? |
In your "paths": {
"@glimmer/component": [
"node_modules/@glimmer/component/addon"
]
}, |
This should be fixed in See : #235 |
PR mentioned above has been merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Using
@glimmer/component
version 0.14.0-alpha.3 with Ember (canary) brings the wrong type definitions for TypeScript users.Current behavior
The types that get used are referent to the glimmer.js implementation of the component.
That implementation is not complaint with Glimmer Components RFC. It includes additional hooks and properties such as
didInsertElement, bounds, element, didUpdate
on the component class.This gives wrong type errors when writing components in TS as well wrong auto complete suggestions.
Reproduction
Expected
Types that reflect actual implementation of Glimmer Components RFC.
The text was updated successfully, but these errors were encountered: