Merge pull request #379 from NullVoxPopuli/fix-ci-34f8a7e7ps

fix ci

Author: chancancode

.github/workflows/ci.yml

@@ -51,7 +51,13 @@ jobs:
 
     strategy:
       matrix:
-        ember-version: [default, release, beta, canary, lts-3.12, lts-3.16]
+        ember-version:
+          - default
+          - release
+          - beta
+          - canary
+          - lts-3.24
+          - lts-3.28
 
     steps:
       - uses: actions/checkout@v2

package.json

@@ -39,10 +39,11 @@
     ]
   },
   "resolutions": {
-    "amd-name-resolver": "https://github.com/ember-cli/amd-name-resolver.git"
+    "amd-name-resolver": "https://github.com/ember-cli/amd-name-resolver.git",
+    "ember-cli-lodash-subset": "2.0.1"
   },
   "devDependencies": {
-    "@babel/core": "^7.9.0",
+    "@babel/core": "^7.17.4",
     "@babel/plugin-proposal-class-properties": "^7.8.3",
     "@babel/plugin-proposal-decorators": "^7.8.3",
     "@babel/preset-env": "^7.9.0",
@@ -61,7 +62,7 @@
     "mkdirp": "^1.0.3",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.0.2",
-    "qunit": "^2.9.3",
+    "qunit": "^2.18.0",
     "release-it": "^13.5.7",
     "release-it-lerna-changelog": "^2.3.0",
     "release-it-yarn-workspaces": "^1.4.0",
@@ -117,7 +118,7 @@
     "npm": false
   },
   "volta": {
-    "node": "12.16.1",
+    "node": "12.22.10",
     "yarn": "1.22.4"
   }
 }

packages/@glimmer/babel-preset/package.json

@@ -11,10 +11,10 @@
   },
   "dependencies": {
     "@babel/plugin-proposal-class-properties": "^7.8.3",
-    "@babel/plugin-proposal-private-methods": "^7.13.0",
     "@babel/plugin-proposal-decorators": "^7.8.3",
-    "@glimmer/compiler": "0.77.6",
-    "@glimmer/vm-babel-plugins": "0.77.6",
+    "@babel/plugin-proposal-private-methods": "^7.13.0",
+    "@glimmer/compiler": "0.84.0",
+    "@glimmer/vm-babel-plugins": "0.84.0",
     "babel-plugin-debug-macros": "^0.3.4",
     "babel-plugin-htmlbars-inline-precompile": "^5.2.0"
   },

packages/@glimmer/babel-preset/test/fixtures/debug/output.js

@@ -4,6 +4,12 @@ import { createTemplateFactory as _createTemplateFactory } from "@glimmer/core";
 
 function _initializerDefineProperty(target, property, descriptor, context) { if (!descriptor) return; Object.defineProperty(target, property, { enumerable: descriptor.enumerable, configurable: descriptor.configurable, writable: descriptor.writable, value: descriptor.initializer ? descriptor.initializer.call(context) : void 0 }); }
 
+function _classPrivateMethodInitSpec(obj, privateSet) { _checkPrivateRedeclaration(obj, privateSet); privateSet.add(obj); }
+
+function _classPrivateFieldInitSpec(obj, privateMap, value) { _checkPrivateRedeclaration(obj, privateMap); privateMap.set(obj, value); }
+
+function _checkPrivateRedeclaration(obj, privateCollection) { if (privateCollection.has(obj)) { throw new TypeError("Cannot initialize the same private elements twice on an object"); } }
+
 function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
 
 function _applyDecoratedDescriptor(target, property, decorators, descriptor, context) { var desc = {}; Object.keys(descriptor).forEach(function (key) { desc[key] = descriptor[key]; }); desc.enumerable = !!desc.enumerable; desc.configurable = !!desc.configurable; if ('value' in desc || desc.initializer) { desc.writable = true; } desc = decorators.slice().reverse().reduce(function (desc, decorator) { return decorator(target, property, desc) || desc; }, desc); if (context && desc.initializer !== void 0) { desc.value = desc.initializer ? desc.initializer.call(context) : void 0; desc.initializer = undefined; } if (desc.initializer === void 0) { Object.defineProperty(target, property, desc); desc = null; } return desc; }
@@ -23,13 +29,13 @@ if (true
 (true && !(false) && deprecate('this is deprecated', false, {
   id: 'foo'
 }));
-let Test = (_class = (_dog = new WeakMap(), _cat = new WeakSet(), class Test {
+let Test = (_class = (_dog = /*#__PURE__*/new WeakMap(), _cat = /*#__PURE__*/new WeakSet(), class Test {
   constructor() {
-    _cat.add(this);
+    _classPrivateMethodInitSpec(this, _cat);
 
     _initializerDefineProperty(this, "bar", _descriptor, this);
 
-    _dog.set(this, {
+    _classPrivateFieldInitSpec(this, _dog, {
       writable: true,
       value: "dog"
     });
@@ -56,6 +62,5 @@ _createTemplateFactory(
   "id": null,
   "block": "[[[1,\"Hello, world!\"]],[],false,[]]",
   "moduleName": "(unknown template module)",
-  "scope": null,
   "isStrictMode": true
-});
+});

packages/@glimmer/babel-preset/test/fixtures/production/output.js

@@ -4,6 +4,12 @@ import { createTemplateFactory as _createTemplateFactory } from "@glimmer/core";
 
 function _initializerDefineProperty(target, property, descriptor, context) { if (!descriptor) return; Object.defineProperty(target, property, { enumerable: descriptor.enumerable, configurable: descriptor.configurable, writable: descriptor.writable, value: descriptor.initializer ? descriptor.initializer.call(context) : void 0 }); }
 
+function _classPrivateMethodInitSpec(obj, privateSet) { _checkPrivateRedeclaration(obj, privateSet); privateSet.add(obj); }
+
+function _classPrivateFieldInitSpec(obj, privateMap, value) { _checkPrivateRedeclaration(obj, privateMap); privateMap.set(obj, value); }
+
+function _checkPrivateRedeclaration(obj, privateCollection) { if (privateCollection.has(obj)) { throw new TypeError("Cannot initialize the same private elements twice on an object"); } }
+
 function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
 
 function _applyDecoratedDescriptor(target, property, decorators, descriptor, context) { var desc = {}; Object.keys(descriptor).forEach(function (key) { desc[key] = descriptor[key]; }); desc.enumerable = !!desc.enumerable; desc.configurable = !!desc.configurable; if ('value' in desc || desc.initializer) { desc.writable = true; } desc = decorators.slice().reverse().reduce(function (desc, decorator) { return decorator(target, property, desc) || desc; }, desc); if (context && desc.initializer !== void 0) { desc.value = desc.initializer ? desc.initializer.call(context) : void 0; desc.initializer = undefined; } if (desc.initializer === void 0) { Object.defineProperty(target, property, desc); desc = null; } return desc; }
@@ -23,13 +29,13 @@ if (false
 (false && !(false) && deprecate('this is deprecated', false, {
   id: 'foo'
 }));
-let Test = (_class = (_dog = new WeakMap(), _cat = new WeakSet(), class Test {
+let Test = (_class = (_dog = /*#__PURE__*/new WeakMap(), _cat = /*#__PURE__*/new WeakSet(), class Test {
   constructor() {
-    _cat.add(this);
+    _classPrivateMethodInitSpec(this, _cat);
 
     _initializerDefineProperty(this, "bar", _descriptor, this);
 
-    _dog.set(this, {
+    _classPrivateFieldInitSpec(this, _dog, {
       writable: true,
       value: "dog"
     });
@@ -56,6 +62,5 @@ _createTemplateFactory(
   "id": null,
   "block": "[[[1,\"Hello, world!\"]],[],false,[]]",
   "moduleName": "(unknown template module)",
-  "scope": null,
   "isStrictMode": true
-});
+});

packages/@glimmer/blueprint/files/package.json

@@ -44,7 +44,7 @@
     "qunit-dom": "^1.1.0",
     "style-loader": "^1.1.3",
     "testem": "^3.0.3",
-    "typescript": "~3.8.3",
+    "typescript": "~4.2.3",
     "webpack": "^4.42.1",
     "webpack-cli": "^3.3.11",
     "webpack-dev-server": "^3.10.3"

packages/@glimmer/component/addon/-private/base-component-manager.ts

@@ -8,7 +8,8 @@ export interface Constructor<T> {
 }
 
 export default abstract class BaseComponentManager<GlimmerComponent extends BaseComponent>
-  implements ComponentManager<GlimmerComponent> {
+  implements ComponentManager<GlimmerComponent>
+{
   abstract capabilities: ComponentCapabilities;
 
   private owner: unknown;

packages/@glimmer/component/addon/-private/ember-component-manager.ts

@@ -1,6 +1,6 @@
 import { DEBUG } from '@glimmer/env';
-import Ember from 'ember';
 import { set } from '@ember/object';
+import { destroy } from '@ember/destroyable';
 import { capabilities } from '@ember/component';
 import { schedule } from '@ember/runloop';
 import { gte } from 'ember-compatibility-helpers';
@@ -21,14 +21,12 @@ const CAPABILITIES = gte('3.13.0-beta.1')
       asyncLifeCycleCallbacks: false,
     });
 
-function scheduledDestroyComponent(component: GlimmerComponent, meta: EmberMeta): void {
+function scheduledDestroyComponent(component: GlimmerComponent): void {
   if (component.isDestroyed) {
     return;
   }
 
-  Ember.destroy(component);
-
-  meta.setSourceDestroyed();
+  destroy(component);
   setDestroyed(component);
 }
 
@@ -46,13 +44,10 @@ class EmberGlimmerComponentManager extends BaseComponentManager<GlimmerComponent
       return;
     }
 
-    const meta = Ember.meta(component);
-
-    meta.setSourceDestroying();
     setDestroying(component);
 
     schedule('actions', component, component.willDestroy);
-    schedule('destroy', this, scheduledDestroyComponent, component, meta);
+    schedule('destroy', this, scheduledDestroyComponent, component);
   }
 }
 

packages/@glimmer/component/config/ember-try.js

@@ -12,18 +12,18 @@ module.exports = function () {
       useYarn: true,
       scenarios: [
         {
-          name: 'ember-lts-3.12',
+          name: 'ember-lts-3.24',
           npm: {
             devDependencies: {
-              'ember-source': '~3.12.0',
+              'ember-source': '~3.24.0',
             },
           },
         },
         {
-          name: 'ember-lts-3.16',
+          name: 'ember-lts-3.28',
           npm: {
             devDependencies: {
-              'ember-source': '~3.16.0',
+              'ember-source': '~3.28.0',
             },
           },
         },

packages/@glimmer/component/ember-cli-build.js

@@ -25,5 +25,12 @@ module.exports = function (defaults) {
     behave. You most likely want to be modifying `./index.js` or app's build file
   */
 
-  return app.toTree();
+  const { maybeEmbroider } = require('@embroider/test-setup');
+  return maybeEmbroider(app, {
+    skipBabel: [
+      {
+        package: 'qunit',
+      },
+    ],
+  });
 };