Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update list of allowed elements #1569

Closed
NullVoxPopuli opened this issue Feb 29, 2024 · 6 comments
Closed

Update list of allowed elements #1569

NullVoxPopuli opened this issue Feb 29, 2024 · 6 comments

Comments

@NullVoxPopuli
Copy link
Contributor

Potentials lists we could use:

What we need:

  • SVG Elements
  • HTML Elements
  • etc?
@NullVoxPopuli
Copy link
Contributor Author

(or remove getTemplateLocals #1550 (comment) )

@NullVoxPopuli NullVoxPopuli mentioned this issue Apr 8, 2024
Closed
@NullVoxPopuli NullVoxPopuli mentioned this issue Oct 16, 2024
Open
@acorncom
Copy link
Member

@NullVoxPopuli is this still needed?

@NullVoxPopuli
Copy link
Contributor Author

Ya

@patricklx
Copy link
Contributor

babel template compilation plugin is not using getTemplateLocals anymore. so, maybe not needed? and just remove the whole list? basically, now, everything is a html element, except if it has a js local.
How does it work for non-strict mode?

emberjs/babel-plugin-ember-template-compilation#33

@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented Oct 17, 2024 •
edited
Loading

Ah! You're right!
That fixes this repro from the linearGradient issue report
#1550

@NullVoxPopuli
Copy link
Contributor Author

We do still need to fix math elements tho:

#1593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support all of the SVG elements glimmerjs/glimmer-vm
3 participants
@NullVoxPopuli @acorncom @patricklx