Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolver#identify should return null whenever a module can't be identified #12

Open
dgeb opened this issue Mar 10, 2017 · 1 comment
Open

Comments

@dgeb
Copy link
Member

dgeb commented Mar 10, 2017

This will allow for better co-existence with other resolvers, like the "unified resolver" being developed for Ember. Otherwise, we'll see performance problems related to catching assertion errors whenever identify fails.

@pittst3r
Copy link
Contributor

@dgeb I'm curious if it would be appropriate to use Option? I don't have all the context for interop so this could be a bad idea, but just a thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants