Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support comments in tsconfig.json #26

Open
tomdale opened this issue Mar 12, 2017 · 1 comment
Open

Support comments in tsconfig.json #26

tomdale opened this issue Mar 12, 2017 · 1 comment

Comments

@tomdale
Copy link
Contributor

tomdale commented Mar 12, 2017

TypeScript supports comments in tsconfig.json, but @glimmer/build currently reads the file in and uses JSON.parse() to parse it, which fails if there are comments. In practice, it means there are some valid tsconfig.json files in the wild that will fail with when used with this tool.

@dgeb
Copy link
Member

dgeb commented May 21, 2019

We should probably use strip-json-comments prior to parsing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants