-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the service worker #28
Comments
I just realized we're not fingerprinting assets so that https://github.com/glimmerjs/glimmer-api-docs/blob/master/workers/service.ts#L42 makes no sense of course 🤦♂️ I guess we should be fingerprinting though or is there any particular reason not to do it? |
Ya, I think we should add fingerprinting back in. It should be as simple as adding |
The fix for now is to delete the service worker manually (or use Safari ;) ) |
Even after deleting the service worker (or when using Safari) it currently doesn't work since one of the broken |
Likewise, the service worker makes no difference (and I don't have Safari as I'm on Linux). I would recommend making your API docs app as simple as possible (render the JSON to HTML, serve it) to ensure high availability of essential developer content. |
I agree with you @kmoe but I think the idea was/is to use the API docs as a show case for Glimmer which makes some sense as well (although it has massively backfired already - mostly my fault messing up the service worker). |
TODO:
It seems that the current service worker can result in empty docs pages for some people. Here's what I see on https://glimmerjs.com/api/:
Also reported here:
The text was updated successfully, but these errors were encountered: