Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onColumnProposeMove doesn't prevent actual column move #945

Open
A-Posthuman opened this issue Apr 16, 2024 · 2 comments · May be fixed by #963
Open

onColumnProposeMove doesn't prevent actual column move #945

A-Posthuman opened this issue Apr 16, 2024 · 2 comments · May be fixed by #963

Comments

@A-Posthuman
Copy link

When using onColumnProposeMove to return false for a given column move, graphically when dragging we see that the columns indeed do not automatically swap places when they otherwise would, however when the mouse up happens and the moved column is "dropped", the column switch still occurs anyway.

An example of this problem can be seen in the Rearrange Columns story, where a function onColProposeMove checks if the endIndex is not 3. If you go to the story and drag the other columns, they instantly swap places when dragged, but column 3 does not, however it still will swap places after you mouse up to release the dragged column.

@BrianHung BrianHung linked a pull request Jun 11, 2024 that will close this issue
@BrianHung
Copy link
Collaborator

Checkout #963 and lmk if that fixes the mouse up behavior.

@A-Posthuman
Copy link
Author

Just tried it, and it seems to work well, thanks! I did still have to adjust the col indexes provided by onColumnProposeMove down by 1 to match my column indexes since I'm using row selectors and that bug isn't fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants