Class.getMethods() returns Object instead of Method[]

[DanStevens]

The getMethods function of the Class class returns an Object rather than an array of Method objects, as the name suggests. This also contradicts the type defined for this method in index.d.ts.

[ichiriac]

Hi @DanStevens,

I'm not sure which the best approach, by one hand, having an object indexed by names of each function is more easy to use, on the other hand, it messes with inheritance, as a function may be overwritten. BTW, it's the same with class properties.

The array may be the simplest approach as it lets the user to implement what it needs, so lets go in that way, but in order to be consistent, properties, constants & others may also follow the same rule.

Dan, if you have some time, could you make the changes and send a PR, and I'll merge it.

[DanStevens]

This is a fair comment. There is also the issue of breaking consumer implementations by changing the returned value from an object to array. Returning an object is an advantage if you know the name of the method you want to work with. The downside is that it's less type safe for Typescript consumers (ignoring the incorrect type definition in index.d.ts).

I'm happy to look into this. I'm learning Typescript so it would be a good exercise.

[DanStevens]

I've been reflecting on this and I'm not sure if it's best to change the implementation to return an array for these methods as this would be a breaking change, although this is inconsistent with other methods that do return arrays (e.g. File.getClasses() or Method.getArguments().

However, what I have done, in pull request #28, is corrected the return types in the type definition file for these methods so that Typescript users can use the return result without errors.

[ichiriac]

I don't know if this module is massively used, but anyway I can release the change on a major version. It's not quite complete to return a name indexed object as on this cases the objets may be defined multiple times as it may handle inheritance and overwriting of methods, interfaces declaration, etc ...

Please could you try a PR with an array implementation, for me it's the best choice as it does not hide information