Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need the licence section at the top of every file? #240

Closed
paddyroddy opened this issue Sep 18, 2024 · 5 comments · Fixed by #252
Closed

Do we need the licence section at the top of every file? #240

paddyroddy opened this issue Sep 18, 2024 · 5 comments · Fixed by #252
Assignees
@ntessore @Saransh-cpp
Labels
question Further information is requested

Comments

@paddyroddy
Copy link
Member

What is the Topic of Your Question

Other

Add Your Question Below

This feels like a relic from the pre-git days, the licence file at the top level is sufficient and covers from a legal point of view (pretty sure)
@paddyroddy paddyroddy added the question Further information is requested label Sep 18, 2024
@ntessore
Copy link
Collaborator

Pretty sure that is only part of the GPL.

@paddyroddy
Copy link
Member Author

Pretty sure that is only part of the GPL.

Yeah, I thought you were using MIT?

@ntessore
Copy link
Collaborator

Oh, I see! You want to remove

# author: Nicolas Tessore <[email protected]>
# license: MIT

from the existing files? Fine by me!

I thought you wanted to add a blurb like

# Heracles: Euclid code for harmonic-space statistics on the sphere
#
# Copyright (C) 2023-2024 Euclid Science Ground Segment
#
# This file is part of Heracles.
#
# Heracles is free software: you can redistribute ...

to all files.

@paddyroddy
Copy link
Member Author

Yeah, removal is what I meant, sorry that wasn't clear

@ntessore
Copy link
Collaborator

Plenty clear, sorry for the confusion

@Saransh-cpp Saransh-cpp self-assigned this Sep 19, 2024
Saransh-cpp added a commit that referenced this issue Sep 19, 2024
@Saransh-cpp
gh-240: remove old file headers (license and author)
a726dd8
@Saransh-cpp Saransh-cpp mentioned this issue Sep 19, 2024
Merged
Saransh-cpp added a commit that referenced this issue Sep 25, 2024
@Saransh-cpp @paddyroddy
gh-240: remove old file headers (license and author) (#252)
fe59545 
Closes: #240

---------

Co-authored-by: Patrick J. Roddy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ntessore ntessore

@Saransh-cpp Saransh-cpp

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-240: remove old file headers (license and author) glass-dev/glass
3 participants
@ntessore @paddyroddy @Saransh-cpp