Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider fixing most/all noqa: statements scattered throughout the code #248

Closed
paddyroddy opened this issue Sep 18, 2024 · 0 comments · Fixed by #394
Closed

Consider fixing most/all noqa: statements scattered throughout the code #248

paddyroddy opened this issue Sep 18, 2024 · 0 comments · Fixed by #394
Assignees
@paddyroddy
Labels
enhancement New feature or request

Comments

@paddyroddy
Copy link
Member

Is Your Feature Request Related to a Problem? Please Describe

To see the list of rules, have a look here, https://docs.astral.sh/ruff/rules. Some of these are trivial, but many are not. The majority of these rules are pretty sensible. The ones with the TODO: listed in #232, I suggest not fixing.

Describe the Solution You'd Like

No response

Describe Alternatives You've Considered

No response

Additional Context

No response
@paddyroddy paddyroddy added the enhancement New feature or request label Sep 18, 2024
@paddyroddy paddyroddy mentioned this issue Sep 18, 2024
Merged
@paddyroddy paddyroddy mentioned this issue Oct 3, 2024
Closed
Saransh-cpp added a commit that referenced this issue Oct 14, 2024
@Saransh-cpp
gh-248: a few fixes for ignored ruff rules
c4698e6
@Saransh-cpp Saransh-cpp mentioned this issue Oct 14, 2024
Merged
Saransh-cpp added a commit that referenced this issue Oct 15, 2024
@Saransh-cpp
gh-248: a few fixes for ignored ruff rules
ca4bb53
Saransh-cpp added a commit that referenced this issue Oct 15, 2024
@Saransh-cpp
gh-248: a few fixes for ignored ruff rules
70ed216
Saransh-cpp added a commit that referenced this issue Oct 15, 2024
@Saransh-cpp
gh-248: a few fixes for ignored and recommended ruff rules (#360)
cfe3245 
Fixed:
- missing-trailing-comma
- commented-out-code
- single-line-implicit-string-concatenation
- numpy-legacy-random
- pytest-raises-too-broad

Refs: #248
@paddyroddy paddyroddy self-assigned this Oct 30, 2024
@paddyroddy paddyroddy mentioned this issue Oct 30, 2024
Merged
paddyroddy added a commit that referenced this issue Nov 7, 2024
@paddyroddy
gh-248: fix all remaining possible ruff # noqa statements (#394)
9075c79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paddyroddy paddyroddy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-248: fix all remaining possible ruff # noqa statements glass-dev/glass
1 participant
@paddyroddy