Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UVUnwrapper.js contains obsolete addAttribute() function #677

Closed
GitHubDragonFly opened this issue Nov 3, 2024 · 2 comments
Closed

UVUnwrapper.js contains obsolete addAttribute() function #677

GitHubDragonFly opened this issue Nov 3, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@GitHubDragonFly
Copy link

Describe the bug

It appears that three.js revisions higher than r140 would throw an error while r139 and r140 log a warning about the addAttribute function being renamed to setAttribute.

Expected behavior

Using the setAttribute() function should eliminate both warnings and errors.

Screenshots and Repro Model

This particular unwrapper I tested as an independent import just to see if it can function as such, without using the three-gpu-pathtracer library (so not sure where exactly in the library this unwrapper might be used).

Platform:

  • Device: [Laptop]
  • OS: [Windows]
  • GPU: [integrated NVidia GeForce]
  • Browser: [Firefox]
  • Browser Version: [132.0 (64-bit)]
  • Three.js version: [r140+]
  • Library version: [v0.0.23]
@GitHubDragonFly GitHubDragonFly added the bug Something isn't working label Nov 3, 2024
@gkjohnson
Copy link
Owner

gkjohnson commented Nov 4, 2024

Thanks - the UVUnwrapper class isn't used and hasn't really been developed and isn't exposed. It was originally added with the plans to (eventually) build it out to support uv unwrapping but that never happened. #670 adds support for some more complete utilities for uv unwrapping and ao mapping but there are still some more changes needed, I think.

The xatlas-three is also a very good xatlas uv unwrapper implementation.

@GitHubDragonFly
Copy link
Author

Just as an FYI, there is a topic in the forum which shows how I experimented with a modified version from your repository and with xatlas-three after you suggested it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants