Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only report new todo's, not existing todo's in files that changed #21

Open
ruudk opened this issue Oct 5, 2023 · 1 comment
Open

Only report new todo's, not existing todo's in files that changed #21

ruudk opened this issue Oct 5, 2023 · 1 comment

Comments

@ruudk
Copy link

ruudk commented Oct 5, 2023

Let's say you have a todo in a file that is in the main branch.

You now create a new branch, and modify that file, and make some changes without touching the todo.

On the PR, it will now comment that you have a todo in that file.

Is that expected? I think not.

In my opinion it should ignore existing todo's that are in the base branch.

@gkampitakis
Copy link
Owner

Hey 👋 thanks for opening this issue and all the prs and discussions. I would swear this is already how this works #9. Maybe there is a weird edge case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants