Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GremlinQueryCreator.java::toCondition() should not change member field 'schema' #48

Open
kerler opened this issue Apr 26, 2016 · 0 comments

Comments

@kerler
Copy link

kerler commented Apr 26, 2016

org.springframework.data.gremlin.query.GremlinQueryCreator.java::toCondition() changes member field 'schema', as make that sometimes GremlinQueryCreator.java::complete() uses member field 'schema' whose value is different against what is set in constructor.

Suggest to define all the member field of GremlinQueryCreator.java to be final, and in toCondition() use a local variable such like 'GremlinSchema tmpSchema = this.schema;'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant