Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kconfig compatibility for the standalone kconfig tool #486

Open
typeless opened this issue Nov 27, 2023 · 0 comments
Open

Kconfig compatibility for the standalone kconfig tool #486

typeless opened this issue Nov 27, 2023 · 0 comments

Comments

@typeless
Copy link

Upon cleaning up a bunch of my messy configs to make it work with the standalone kconfig tool, I found some unexpected behavior.

Looking into https://github.com/gittup/tup/blob/master/src/tup/db.c#L7710-L7722, it appears
that ifdef CONFIG_FOO would come into FOO=n (where FOO is considered defined) if Tup finds a # CONFIG_ line in the config file. This is not compatible with the convention used by Make and Kconfig (AFAIK), where a commented CONFIG symbol such as # CONFIG_FOO is not set is evaluated to 'true' for ifndef when imported to Makefiles.

For now, I have to update all the ifdef and ifndef to become ifneq in our Tupfiles to work-around the behavior.

In summary:
Expected:
# CONFIG_FOO is not set in a config should evaluate the statements in the ifndef CONFIG_FOO ... endif block

Actual:
# CONFIG_FOO is not set in a config doesn't evaluate the statements in the ifndef CONFIG_FOO ... endif block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant