[server] Fix mis-reporting of errors as "success" (in addition) (#19750)

Author: geropl

components/server/src/user/token-service.ts

@@ -125,9 +125,10 @@ export class TokenService implements TokenProvider {
                     // Perform actual refresh
                     const stopTimer = scmTokenRefreshLatencyHistogram.startTimer({ host });
                     try {
-                        return await authProvider.refreshToken(user, requestedLifetimeDate);
-                    } finally {
+                        const result = await authProvider.refreshToken(user, requestedLifetimeDate);
                         reportScmTokenRefreshRequest(host, opportunisticRefresh, "success");
+                        return result;
+                    } finally {
                         stopTimer({ host });
                     }
                 },