Skip to content

Commit d70aaba

Browse files
afonsojramosafonsojramos
authored
chore(deps): upgrade @primer/octicons-react (#602)
1 parent 7ffc21f commit d70aaba

12 files changed

+127
-100
lines changed

‎package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@
105105
"afterSign": "scripts/notarize.js"
106106
},
107107
"dependencies": {
108-
"@primer/octicons-react": "^11.2.0",
108+
"@primer/octicons-react": "^19.8.0",
109109
"axios": "=0.27.2",
110110
"date-fns": "^2.16.1",
111111
"electron-updater": "^4.3.9",

‎pnpm-lock.yaml

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/components/Sidebar.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as Octicons from '@primer/octicons-react';
1+
import { BellIcon } from '@primer/octicons-react';
22
import { ipcRenderer, shell } from 'electron';
33
import React, { useCallback, useContext, useMemo } from 'react';
44
import { useHistory, useLocation } from 'react-router-dom';
@@ -55,7 +55,7 @@ export const Sidebar: React.FC = () => {
5555
onClick={onOpenGitHubNotifications}
5656
aria-label={`${notificationsCount} Unread Notifications`}
5757
>
58-
<Octicons.BellIcon size={12} />
58+
<BellIcon size={12} />
5959
{notificationsCount > 0 && notificationsCount}
6060
</div>
6161
</div>

‎src/components/__snapshots__/AccountNotifications.test.tsx.snap

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,25 +8,26 @@ Array [
88
github.com
99
<svg
1010
aria-hidden="true"
11-
className="octicon"
12-
dangerouslySetInnerHTML={
13-
Object {
14-
"__html": "<path fill-rule=\\"evenodd\\" d=\\"M12.78 6.22a.75.75 0 010 1.06l-4.25 4.25a.75.75 0 01-1.06 0L3.22 7.28a.75.75 0 011.06-1.06L8 9.94l3.72-3.72a.75.75 0 011.06 0z\\"></path>",
15-
}
16-
}
11+
className="octicon octicon-chevron-down"
1712
fill="currentColor"
13+
focusable="false"
1814
height={20}
1915
role="img"
2016
style={
2117
Object {
2218
"display": "inline-block",
19+
"overflow": "visible",
2320
"userSelect": "none",
2421
"verticalAlign": "text-bottom",
2522
}
2623
}
2724
viewBox="0 0 16 16"
2825
width={20}
29-
/>
26+
>
27+
<path
28+
d="M12.78 5.22a.749.749 0 0 1 0 1.06l-4.25 4.25a.749.749 0 0 1-1.06 0L3.22 6.28a.749.749 0 1 1 1.06-1.06L8 8.939l3.72-3.719a.749.749 0 0 1 1.06 0Z"
29+
/>
30+
</svg>
3031
</div>,
3132
<div>
3233
Repository
@@ -41,24 +42,25 @@ exports[`components/AccountNotifications.tsx should render itself (github.com wi
4142
github.com
4243
<svg
4344
aria-hidden="true"
44-
className="octicon"
45-
dangerouslySetInnerHTML={
46-
Object {
47-
"__html": "<path fill-rule=\\"evenodd\\" d=\\"M9.78 12.78a.75.75 0 01-1.06 0L4.47 8.53a.75.75 0 010-1.06l4.25-4.25a.75.75 0 011.06 1.06L6.06 8l3.72 3.72a.75.75 0 010 1.06z\\"></path>",
48-
}
49-
}
45+
className="octicon octicon-chevron-left"
5046
fill="currentColor"
47+
focusable="false"
5148
height={20}
5249
role="img"
5350
style={
5451
Object {
5552
"display": "inline-block",
53+
"overflow": "visible",
5654
"userSelect": "none",
5755
"verticalAlign": "text-bottom",
5856
}
5957
}
6058
viewBox="0 0 16 16"
6159
width={20}
62-
/>
60+
>
61+
<path
62+
d="M9.78 12.78a.75.75 0 0 1-1.06 0L4.47 8.53a.75.75 0 0 1 0-1.06l4.25-4.25a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042L6.06 8l3.72 3.72a.75.75 0 0 1 0 1.06Z"
63+
/>
64+
</svg>
6365
</div>
6466
`;

‎src/components/__snapshots__/NotificationRow.test.tsx.snap

Lines changed: 25 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -10,25 +10,29 @@ exports[`components/Notification.js should render itself & its children 1`] = `
1010
<svg
1111
aria-hidden="false"
1212
aria-label="Issue"
13-
className="octicon"
14-
dangerouslySetInnerHTML={
15-
Object {
16-
"__html": "<path fill-rule=\\"evenodd\\" d=\\"M8 1.5a6.5 6.5 0 100 13 6.5 6.5 0 000-13zM0 8a8 8 0 1116 0A8 8 0 010 8zm9 3a1 1 0 11-2 0 1 1 0 012 0zm-.25-6.25a.75.75 0 00-1.5 0v3.5a.75.75 0 001.5 0v-3.5z\\"></path>",
17-
}
18-
}
13+
className="octicon octicon-issue-opened"
1914
fill="currentColor"
15+
focusable="false"
2016
height={18}
2117
role="img"
2218
style={
2319
Object {
2420
"display": "inline-block",
21+
"overflow": "visible",
2522
"userSelect": "none",
2623
"verticalAlign": "text-bottom",
2724
}
2825
}
2926
viewBox="0 0 16 16"
3027
width={18}
31-
/>
28+
>
29+
<path
30+
d="M8 9.5a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"
31+
/>
32+
<path
33+
d="M8 0a8 8 0 1 1 0 16A8 8 0 0 1 8 0ZM1.5 8a6.5 6.5 0 1 0 13 0 6.5 6.5 0 0 0-13 0Z"
34+
/>
35+
</svg>
3236
</div>
3337
<div
3438
className="flex-1 overflow-hidden"
@@ -60,24 +64,25 @@ exports[`components/Notification.js should render itself & its children 1`] = `
6064
aria-hidden="false"
6165
aria-label="Unsubscribe"
6266
className="hover:text-red-500"
63-
dangerouslySetInnerHTML={
64-
Object {
65-
"__html": "<path fill-rule=\\"evenodd\\" d=\\"M8 2.75a.75.75 0 00-1.238-.57L3.472 5H1.75A1.75 1.75 0 000 6.75v2.5C0 10.216.784 11 1.75 11h1.723l3.289 2.82A.75.75 0 008 13.25V2.75zM4.238 6.32L6.5 4.38v7.24L4.238 9.68a.75.75 0 00-.488-.18h-2a.25.25 0 01-.25-.25v-2.5a.25.25 0 01.25-.25h2a.75.75 0 00.488-.18zm7.042-1.1a.75.75 0 10-1.06 1.06L11.94 8l-1.72 1.72a.75.75 0 101.06 1.06L13 9.06l1.72 1.72a.75.75 0 101.06-1.06L14.06 8l1.72-1.72a.75.75 0 00-1.06-1.06L13 6.94l-1.72-1.72z\\"></path>",
66-
}
67-
}
6867
fill="currentColor"
68+
focusable="false"
6969
height={13}
7070
role="img"
7171
style={
7272
Object {
7373
"display": "inline-block",
74+
"overflow": "visible",
7475
"userSelect": "none",
7576
"verticalAlign": "text-bottom",
7677
}
7778
}
7879
viewBox="0 0 16 16"
7980
width={13}
80-
/>
81+
>
82+
<path
83+
d="M8 2.75v10.5a.751.751 0 0 1-1.238.57L3.473 11H1.75A1.75 1.75 0 0 1 0 9.25v-2.5C0 5.784.784 5 1.75 5h1.722l3.29-2.82A.75.75 0 0 1 8 2.75Zm3.28 2.47L13 6.94l1.72-1.72a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042L14.06 8l1.72 1.72a.749.749 0 0 1-.326 1.275.749.749 0 0 1-.734-.215L13 9.06l-1.72 1.72a.749.749 0 0 1-1.275-.326.749.749 0 0 1 .215-.734L11.94 8l-1.72-1.72a.749.749 0 0 1 .326-1.275.749.749 0 0 1 .734.215Zm-7.042 1.1a.752.752 0 0 1-.488.18h-2a.25.25 0 0 0-.25.25v2.5c0 .138.112.25.25.25h2c.179 0 .352.064.488.18L6.5 11.62V4.38Z"
84+
/>
85+
</svg>
8186
</button>
8287
</div>
8388
</div>
@@ -93,24 +98,25 @@ exports[`components/Notification.js should render itself & its children 1`] = `
9398
aria-hidden="false"
9499
aria-label="Mark as Read"
95100
className="hover:text-green-500"
96-
dangerouslySetInnerHTML={
97-
Object {
98-
"__html": "<path fill-rule=\\"evenodd\\" d=\\"M13.78 4.22a.75.75 0 010 1.06l-7.25 7.25a.75.75 0 01-1.06 0L2.22 9.28a.75.75 0 011.06-1.06L6 10.94l6.72-6.72a.75.75 0 011.06 0z\\"></path>",
99-
}
100-
}
101101
fill="currentColor"
102+
focusable="false"
102103
height={20}
103104
role="img"
104105
style={
105106
Object {
106107
"display": "inline-block",
108+
"overflow": "visible",
107109
"userSelect": "none",
108110
"verticalAlign": "text-bottom",
109111
}
110112
}
111113
viewBox="0 0 16 16"
112114
width={20}
113-
/>
115+
>
116+
<path
117+
d="M13.78 4.22a.75.75 0 0 1 0 1.06l-7.25 7.25a.75.75 0 0 1-1.06 0L2.22 9.28a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018L6 10.94l6.72-6.72a.75.75 0 0 1 1.06 0Z"
118+
/>
119+
</svg>
114120
</button>
115121
</div>
116122
</div>

‎src/components/__snapshots__/Repository.test.tsx.snap

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,24 +29,25 @@ Array [
2929
aria-hidden="false"
3030
aria-label="Mark Repository as Read"
3131
className="hover:text-green-500"
32-
dangerouslySetInnerHTML={
33-
Object {
34-
"__html": "<path fill-rule=\\"evenodd\\" d=\\"M13.78 4.22a.75.75 0 010 1.06l-7.25 7.25a.75.75 0 01-1.06 0L2.22 9.28a.75.75 0 011.06-1.06L6 10.94l6.72-6.72a.75.75 0 011.06 0z\\"></path>",
35-
}
36-
}
3732
fill="currentColor"
33+
focusable="false"
3834
height={20}
3935
role="img"
4036
style={
4137
Object {
4238
"display": "inline-block",
39+
"overflow": "visible",
4340
"userSelect": "none",
4441
"verticalAlign": "text-bottom",
4542
}
4643
}
4744
viewBox="0 0 16 16"
4845
width={20}
49-
/>
46+
>
47+
<path
48+
d="M13.78 4.22a.75.75 0 0 1 0 1.06l-7.25 7.25a.75.75 0 0 1-1.06 0L2.22 9.28a.751.751 0 0 1 .018-1.042.751.751 0 0 1 1.042-.018L6 10.94l6.72-6.72a.75.75 0 0 1 1.06 0Z"
49+
/>
50+
</svg>
5051
</button>
5152
</div>
5253
</div>,

‎src/components/__snapshots__/Sidebar.test.tsx.snap

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -59,25 +59,26 @@ exports[`components/Sidebar.tsx should render itself & its children (logged in)
5959
>
6060
<svg
6161
aria-hidden="true"
62-
className="octicon"
63-
dangerouslySetInnerHTML={
64-
Object {
65-
"__html": "<path d=\\"M8 16a2 2 0 001.985-1.75c.017-.137-.097-.25-.235-.25h-3.5c-.138 0-.252.113-.235.25A2 2 0 008 16z\\"></path><path fill-rule=\\"evenodd\\" d=\\"M8 1.5A3.5 3.5 0 004.5 5v2.947c0 .346-.102.683-.294.97l-1.703 2.556a.018.018 0 00-.003.01l.001.006c0 .002.002.004.004.006a.017.017 0 00.006.004l.007.001h10.964l.007-.001a.016.016 0 00.006-.004.016.016 0 00.004-.006l.001-.007a.017.017 0 00-.003-.01l-1.703-2.554a1.75 1.75 0 01-.294-.97V5A3.5 3.5 0 008 1.5zM3 5a5 5 0 0110 0v2.947c0 .05.015.098.042.139l1.703 2.555A1.518 1.518 0 0113.482 13H2.518a1.518 1.518 0 01-1.263-2.36l1.703-2.554A.25.25 0 003 7.947V5z\\"></path>",
66-
}
67-
}
62+
className="octicon octicon-bell"
6863
fill="currentColor"
64+
focusable="false"
6965
height={12}
7066
role="img"
7167
style={
7268
Object {
7369
"display": "inline-block",
70+
"overflow": "visible",
7471
"userSelect": "none",
7572
"verticalAlign": "text-bottom",
7673
}
7774
}
7875
viewBox="0 0 16 16"
7976
width={12}
80-
/>
77+
>
78+
<path
79+
d="M8 16a2 2 0 0 0 1.985-1.75c.017-.137-.097-.25-.235-.25h-3.5c-.138 0-.252.113-.235.25A2 2 0 0 0 8 16ZM3 5a5 5 0 0 1 10 0v2.947c0 .05.015.098.042.139l1.703 2.555A1.519 1.519 0 0 1 13.482 13H2.518a1.516 1.516 0 0 1-1.263-2.36l1.703-2.554A.255.255 0 0 0 3 7.947Zm5-3.5A3.5 3.5 0 0 0 4.5 5v2.947c0 .346-.102.683-.294.97l-1.703 2.556a.017.017 0 0 0-.003.01l.001.006c0 .002.002.004.004.006l.006.004.007.001h10.964l.007-.001.006-.004.004-.006.001-.007a.017.017 0 0 0-.003-.01l-1.703-2.554a1.745 1.745 0 0 1-.294-.97V5A3.5 3.5 0 0 0 8 1.5Z"
80+
/>
81+
</svg>
8182
4
8283
</div>
8384
</div>
@@ -178,25 +179,26 @@ exports[`components/Sidebar.tsx should render itself & its children (logged out)
178179
>
179180
<svg
180181
aria-hidden="true"
181-
className="octicon"
182-
dangerouslySetInnerHTML={
183-
Object {
184-
"__html": "<path d=\\"M8 16a2 2 0 001.985-1.75c.017-.137-.097-.25-.235-.25h-3.5c-.138 0-.252.113-.235.25A2 2 0 008 16z\\"></path><path fill-rule=\\"evenodd\\" d=\\"M8 1.5A3.5 3.5 0 004.5 5v2.947c0 .346-.102.683-.294.97l-1.703 2.556a.018.018 0 00-.003.01l.001.006c0 .002.002.004.004.006a.017.017 0 00.006.004l.007.001h10.964l.007-.001a.016.016 0 00.006-.004.016.016 0 00.004-.006l.001-.007a.017.017 0 00-.003-.01l-1.703-2.554a1.75 1.75 0 01-.294-.97V5A3.5 3.5 0 008 1.5zM3 5a5 5 0 0110 0v2.947c0 .05.015.098.042.139l1.703 2.555A1.518 1.518 0 0113.482 13H2.518a1.518 1.518 0 01-1.263-2.36l1.703-2.554A.25.25 0 003 7.947V5z\\"></path>",
185-
}
186-
}
182+
className="octicon octicon-bell"
187183
fill="currentColor"
184+
focusable="false"
188185
height={12}
189186
role="img"
190187
style={
191188
Object {
192189
"display": "inline-block",
190+
"overflow": "visible",
193191
"userSelect": "none",
194192
"verticalAlign": "text-bottom",
195193
}
196194
}
197195
viewBox="0 0 16 16"
198196
width={12}
199-
/>
197+
>
198+
<path
199+
d="M8 16a2 2 0 0 0 1.985-1.75c.017-.137-.097-.25-.235-.25h-3.5c-.138 0-.252.113-.235.25A2 2 0 0 0 8 16ZM3 5a5 5 0 0 1 10 0v2.947c0 .05.015.098.042.139l1.703 2.555A1.519 1.519 0 0 1 13.482 13H2.518a1.516 1.516 0 0 1-1.263-2.36l1.703-2.554A.255.255 0 0 0 3 7.947Zm5-3.5A3.5 3.5 0 0 0 4.5 5v2.947c0 .346-.102.683-.294.97l-1.703 2.556a.017.017 0 0 0-.003.01l.001.006c0 .002.002.004.004.006l.006.004.007.001h10.964l.007-.001.006-.004.004-.006.001-.007a.017.017 0 0 0-.003-.01l-1.703-2.554a1.745 1.745 0 0 1-.294-.97V5A3.5 3.5 0 0 0 8 1.5Z"
200+
/>
201+
</svg>
200202
4
201203
</div>
202204
</div>

‎src/routes/__snapshots__/LoginEnterprise.test.tsx.snap

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,24 +15,25 @@ exports[`routes/LoginEnterprise.js renders correctly 1`] = `
1515
<svg
1616
aria-hidden="true"
1717
className="hover:text-gray-400"
18-
dangerouslySetInnerHTML={
19-
Object {
20-
"__html": "<path fill-rule=\\"evenodd\\" d=\\"M7.78 12.53a.75.75 0 01-1.06 0L2.47 8.28a.75.75 0 010-1.06l4.25-4.25a.75.75 0 011.06 1.06L4.81 7h7.44a.75.75 0 010 1.5H4.81l2.97 2.97a.75.75 0 010 1.06z\\"></path>",
21-
}
22-
}
2318
fill="currentColor"
19+
focusable="false"
2420
height={20}
2521
role="img"
2622
style={
2723
Object {
2824
"display": "inline-block",
25+
"overflow": "visible",
2926
"userSelect": "none",
3027
"verticalAlign": "text-bottom",
3128
}
3229
}
3330
viewBox="0 0 16 16"
3431
width={20}
35-
/>
32+
>
33+
<path
34+
d="M7.78 12.53a.75.75 0 0 1-1.06 0L2.47 8.28a.75.75 0 0 1 0-1.06l4.25-4.25a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042L4.81 7h7.44a.75.75 0 0 1 0 1.5H4.81l2.97 2.97a.75.75 0 0 1 0 1.06Z"
35+
/>
36+
</svg>
3637
</button>
3738
<h3
3839
className="text-lg font-semibold"

‎src/routes/__snapshots__/LoginWithToken.test.tsx.snap

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,24 +15,25 @@ exports[`routes/LoginWithToken.js renders correctly 1`] = `
1515
<svg
1616
aria-hidden="true"
1717
className="hover:text-gray-400"
18-
dangerouslySetInnerHTML={
19-
Object {
20-
"__html": "<path fill-rule=\\"evenodd\\" d=\\"M7.78 12.53a.75.75 0 01-1.06 0L2.47 8.28a.75.75 0 010-1.06l4.25-4.25a.75.75 0 011.06 1.06L4.81 7h7.44a.75.75 0 010 1.5H4.81l2.97 2.97a.75.75 0 010 1.06z\\"></path>",
21-
}
22-
}
2318
fill="currentColor"
19+
focusable="false"
2420
height={20}
2521
role="img"
2622
style={
2723
Object {
2824
"display": "inline-block",
25+
"overflow": "visible",
2926
"userSelect": "none",
3027
"verticalAlign": "text-bottom",
3128
}
3229
}
3330
viewBox="0 0 16 16"
3431
width={20}
35-
/>
32+
>
33+
<path
34+
d="M7.78 12.53a.75.75 0 0 1-1.06 0L2.47 8.28a.75.75 0 0 1 0-1.06l4.25-4.25a.751.751 0 0 1 1.042.018.751.751 0 0 1 .018 1.042L4.81 7h7.44a.75.75 0 0 1 0 1.5H4.81l2.97 2.97a.75.75 0 0 1 0 1.06Z"
35+
/>
36+
</svg>
3637
</button>
3738
<h3
3839
className="text-lg font-semibold"

0 commit comments

Comments
 (0)