react-solution not spinning up

[brianamarie]

Bug Report

Current behavior
The repository used as a "solution", https://github.com/githubtraining/react-solution/, will not spin up correctly locally with npm start.

Reproduction
Steps to reproduce the behavior in the course:

1. Clone https://github.com/githubtraining/react-solution/
2. CD into the repo
3. Run npm start
4. See error

Expected behavior
I would expect the solution repository to be able to work immediately upon clone

Additional context
I found this out when testing a dependabot PR - I wanted to see that things worked as they would on master and found that master doesn't work either.

Whatever the solution is, it should probably also be applied to https://github.com/githubtraining/react-template/.

cc @hectorsector @partyshah

[Sid-ah]

You’re missing a step which is to run npm install. It will install the required libraries and one of those libraries is react-scripts, which is responsible for spinning up the project.

[mattdavis0351]

@brianamarie we wouldn't want to add the dependencies to the template repo. That's against best practice. @hectorsector what are your thoughts on adding dependencies to the template repo? If you are in the camp of not doing so (the better camp 😉 ) then this issue can be moved along to done in the triage board.

The README in https://github.com/githubtraining/react-solution/ is the default create-react-app README. The solution to this would be to edit that README to include proper steps for running the app. Which is a different work item.

Edit:

I have updated the README to include an npm install step.

[hectorsector]

The solution isn't the template repo though, right?