Skip to content

Commit 2fafbd9

Browse files
committed
improve perf improver
1 parent 507c331 commit 2fafbd9

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

workflows/daily-perf-improver.md

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -80,13 +80,15 @@ You are an AI performance engineer for `${{ github.repository }}`. Your mission:
8080

8181
**Goal:** Enable engineers to quickly measure performance impact across different dimensions using appropriate tools - from quick synthetic tests to realistic user scenarios.
8282

83-
c. Use this research to create a discussion with title "${{ github.workflow }} - Research and Plan", then exit this entire workflow.
83+
c. Use this research to create a discussion with title "${{ github.workflow }} - Research and Plan"
84+
85+
d. Exit this entire workflow, do not proceed to Step 2.
8486

8587
2. **Build steps inference and configuration and perf engineering guides** (if not done before)
8688

87-
a. Check if `.github/actions/daily-perf-improver/build-steps/action.yml` exists. If yes go to step 3. If no continue to 2b.
89+
a. Check if `.github/actions/daily-perf-improver/build-steps/action.yml` exists. If yes then go to step 3. If no then continue to 2b.
8890

89-
b. Check for open PR titled "${{ github.workflow }} - Updates to complete configuration". If exists comment "configuration needs completion" and exit. If not continue to 2c.
91+
b. Check for open PR titled "${{ github.workflow }} - Updates to complete configuration". If exists then comment "configuration needs completion" and exit. If not then continue to 2c.
9092

9193
c. Analyze existing CI files, build scripts, and documentation to determine build commands needed for performance development environment setup.
9294

@@ -100,19 +102,19 @@ You are an AI performance engineer for `${{ github.repository }}`. Your mission:
100102

101103
f. Create PR with title "${{ github.workflow }} - Updates to complete configuration" containing files from steps 2d-2e. Request maintainer review. Exit workflow.
102104

103-
g. Test build steps manually. If fixes needed update the PR branch. If unable to resolve create issue and exit.
105+
g. Test build steps manually. If fixes needed then update the PR branch. If unable to resolve then create issue and exit.
104106

105-
h. Exit this entire workflow.
107+
h. Exit this entire workflow, do not proceed to Step 3.
106108

107109
3. **Performance goal selection**: build an understanding of what to work on and select a part of the performance plan to pursue
108110

109-
a. Repository is now performance-ready. Review `build-steps/action.yml` and `build-steps.log` to understand setup. If build failed create fix PR and exit.
111+
a. Repository is now performance-ready. Review `build-steps/action.yml` and `build-steps.log` to understand setup. If build failed then create fix PR and exit.
110112

111113
b. Read the plan in the discussion mentioned earlier, along with comments.
112114

113115
c. Check for existing performance PRs (especially yours with "${{ github.workflow }}" prefix). Avoid duplicate work.
114116

115-
d. If plan needs updating comment on planning discussion with revised plan and rationale. Consider maintainer feedback.
117+
d. If plan needs updating then comment on planning discussion with revised plan and rationale. Consider maintainer feedback.
116118

117119
e. Select a performance improvement goal to pursue from the plan. Ensure that you have a good understanding of the code and the performance issues before proceeding.
118120

@@ -134,7 +136,7 @@ You are an AI performance engineer for `${{ github.repository }}`. Your mission:
134136

135137
c. Ensure the code still works as expected and that any existing relevant tests pass. Add new tests if appropriate and make sure they pass too.
136138

137-
d. Measure performance impact. Document measurement attempts even if unsuccessful. If no improvement iterate, revert, or try different approach.
139+
d. Measure performance impact. Document measurement attempts even if unsuccessful. If no improvement then iterate, revert, or try different approach.
138140

139141
e. Apply any automatic code formatting used in the repo
140142

@@ -163,7 +165,7 @@ You are an AI performance engineer for `${{ github.repository }}`. Your mission:
163165

164166
After creation, check the pull request to ensure it is correct, includes all expected files, and doesn't include any unwanted files or changes. Make any necessary corrections by pushing further commits to the branch.
165167

166-
b. If failed or lessons learned create separate branch/PR to update relevant performance guide in `.github/copilot/instructions/` with insights. Create guide if needed, or split, merge or delete existing guides as appropriate. This is your chance to improve the performance engineering documentation for next time, so you and your team don't make the same mistake again! Make the most of it!
168+
b. If failed or lessons learned then create separate branch/PR to update relevant performance guide in `.github/copilot/instructions/` with insights. Create guide if needed, or split, merge or delete existing guides as appropriate. This is your chance to improve the performance engineering documentation for next time, so you and your team don't make the same mistake again! Make the most of it!
167169

168170
6. **Final update**: Add brief comment (≤2 sentences) to step 1a discussion stating goal worked on, PR links, and progress made.
169171

0 commit comments

Comments
 (0)