Skip to content

Commit fb1ebe3

Browse files
authored
Merge pull request #9 from github/avoid-threshold-check
Avoid threshold check
2 parents 0ee7231 + ebee798 commit fb1ebe3

File tree

3 files changed

+6
-13
lines changed

3 files changed

+6
-13
lines changed

dist/index.js

Lines changed: 2 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/get-stats-diff.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ export type StatDiff = {
66
diff: number
77
diffPercentage: number
88
}
9+
910
function indexNameToSize(
1011
statAssets: StatsCompilation['assets'] = []
1112
): Record<string, number> {
@@ -77,13 +78,9 @@ function webpackStatsDiff(
7778
} else {
7879
const diff = {name, ...createDiff(oldAssetSize, newAssets[name])}
7980

80-
/**
81-
* Providing a small threshold for the diff to be considered "bigger"/"smaller"
82-
* to account for minor variance in webpack output for the same asset.
83-
*/
84-
if (diff.diffPercentage > 5) {
81+
if (diff.diffPercentage > 0) {
8582
bigger.push(diff)
86-
} else if (diff.diffPercentage < -5) {
83+
} else if (diff.diffPercentage < 0) {
8784
smaller.push(diff)
8885
} else {
8986
unchanged.push(diff)

0 commit comments

Comments
 (0)