Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unmaintained child-process-promise #3839

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

koesie10
Copy link
Member

@koesie10 koesie10 commented Nov 22, 2024

child-process-promise seems to be unmaintained, so this removes it and replaces it by creating the promise manually and using cross-spawn for spawning (like child-process-promise did).

The only time this code is actually used is when running tests. Running CodeQL tests in github/codeql still works, so there should be no changes in behavior.

@koesie10 koesie10 force-pushed the koesie10/switch-to-execa branch 3 times, most recently from 6e3497b to f625fec Compare November 22, 2024 13:03
@koesie10 koesie10 changed the title Switch from unmaintained child-process-promise to execa Remove unmaintained child-process-promise Nov 22, 2024
@koesie10 koesie10 marked this pull request as ready for review November 22, 2024 13:43
@koesie10 koesie10 requested a review from a team as a code owner November 22, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant