Assert checkbox state inside waitFor in RepoRow tests

The findCheckbox helper only waited for the vscode-checkbox element to
exist, not for Lit to reflect the disabled property to an attribute, so
the enabled/disabled assertions at each call site raced the async
update. Move the assertion into the waitFor callback via an expected
state argument so the retry loop waits for reflection.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0f8ebf0f-6429-4147-b7eb-ffacf1a942da

Author: nickrolfe

extensions/ql-vscode/src/view/variant-analysis/__tests__/RepoRow.spec.tsx

@@ -34,12 +34,20 @@ describe(RepoRow.name, () => {
   // which testing-library cannot reach), so find it by tag name instead. The
   // `disabled` property is reflected to a `disabled` attribute asynchronously by
   // Lit, so wait for the expected state.
-  const findCheckbox = async (container: HTMLElement): Promise<HTMLElement> => {
+  const findCheckbox = async (
+    container: HTMLElement,
+    expected: "enabled" | "disabled",
+  ): Promise<HTMLElement> => {
     return waitFor(() => {
       const checkbox = container.querySelector("vscode-checkbox");
       if (!checkbox) {
         throw new Error("Unable to find a vscode-checkbox element");
       }
+      if (expected === "disabled") {
+        expect(checkbox).toBeDisabled();
+      } else {
+        expect(checkbox).toBeEnabled();
+      }
       return checkbox as HTMLElement;
     });
   };
@@ -418,17 +426,15 @@ describe(RepoRow.name, () => {
       status: VariantAnalysisRepoStatus.InProgress,
     });
 
-    const checkbox = await findCheckbox(container);
-    expect(checkbox).toBeDisabled();
+    await findCheckbox(container, "disabled");
   });
 
   it("does not allow selecting the item if the item has not been downloaded", async () => {
     const { container } = render({
       status: VariantAnalysisRepoStatus.Succeeded,
     });
 
-    const checkbox = await findCheckbox(container);
-    expect(checkbox).toBeDisabled();
+    await findCheckbox(container, "disabled");
   });
 
   it("does not allow selecting the item if the item has not been downloaded successfully", async () => {
@@ -440,8 +446,7 @@ describe(RepoRow.name, () => {
       },
     });
 
-    const checkbox = await findCheckbox(container);
-    expect(checkbox).toBeDisabled();
+    await findCheckbox(container, "disabled");
   });
 
   it("allows selecting the item if the item has been downloaded", async () => {
@@ -454,7 +459,6 @@ describe(RepoRow.name, () => {
       },
     });
 
-    const checkbox = await findCheckbox(container);
-    expect(checkbox).toBeEnabled();
+    await findCheckbox(container, "enabled");
   });
 });