From 1bc13d70ce2aae87cdc711bb813d9072115f9768 Mon Sep 17 00:00:00 2001 From: Koen Vlaswinkel Date: Wed, 29 May 2024 11:22:03 +0200 Subject: [PATCH] Update test plan This fixes the model pack query to account for the new MAD ID in the `sinkModel` and removes the LLM section. --- docs/test-plan.md | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/docs/test-plan.md b/docs/test-plan.md index 561d86a666b..b5441f60b54 100644 --- a/docs/test-plan.md +++ b/docs/test-plan.md @@ -179,7 +179,7 @@ Run one of the above MRVAs, but cancel it from within VS Code: import semmle.python.frameworks.data.internal.ApiGraphModelsExtensions from string path, string kind - where sinkModel("vscode-codeql", path, kind) + where sinkModel("vscode-codeql", path, kind, _) select path, kind ``` @@ -210,17 +210,7 @@ Run one of the above MRVAs, but cancel it from within VS Code: 4. Open the ".model.yml" file corresponding to the library that was changed. - Check that the file contains entries for the methods that were modeled. -#### Test Case 3: Model with AI - -Note that this test requires the feature flag: `codeQL.model.llmGeneration` - -A package that the AI normally gives models for is `javax.servlet-api` from the `jhy/jsoup` repository. - -1. Click "Model with AI". - - Check that rows change to "Thinking". - - Check that results come back and rows get filled out. - -#### Test Case 4: Model as dependency +#### Test Case 3: Model as dependency Note that this test requires the feature flag: `codeQL.model.flowGeneration`