Fix RemoveTablet during TabletExternallyReparented causing connection issues
#112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljoos
force-pushed
the
arthur/add-more-logs
branch
from
31c572a
to
f0b2004
Compare
danieljoos
changed the title
vtgate / healthcheckRemoveTablet during TabletExternallyReparented causing connection issues
danieljoos
force-pushed
the
arthur/add-more-logs
branch
from
f0b2004
to
37dbdf2
Compare
arthurschreiber
commented
Jul 12, 2024
This ensures that we can never end up in a situation where there is more than one healthy primary tablet for a given shard. Signed-off-by: Arthur Schreiber <[email protected]> Co-authored-by: Daniel Joos <[email protected]>
danieljoos
force-pushed
the
arthur/add-more-logs
branch
from
37dbdf2
to
9894a65
Compare
ericyan
approved these changes
Jul 16, 2024
|
Deployed to all production vtgates. Merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request backports the changes proposed in vitessio#16371.
It fixes a problem in the health-check logic where an external reparenting can cause two primary tablets being marked as healthy.
Related Issue(s)
Checklist
Deployment Notes